Hey Eric,

Le 25 août 08 à 01:55, Eric Wasylishen a écrit :

> Hey Quentin,
> Melodie seems to work with your recent changes. :)

Great :)
The compilation fails for me though, I got the following error:
TLMusicFile.m: In function ‘-[TLMusicFile mp4ReadTagsForFile:]’:
TLMusicFile.m:70: error: too many arguments to function  
‘MP4GetMetadataCoverArt’
TLMusicFile.m: In function ‘-[TLMusicFile cover]’:
TLMusicFile.m:185: error: too many arguments to function  
‘MP4GetMetadataCoverArt’

May be you switched to a more recent version of the mp4 lib? Mine is 
<http://packages.ubuntu.com/search?suite=gutsy&searchon=names&keywords=libmp4 
 >

> I attached the small CoreObject changes we discussed a few weeks ago.
> (Make the API consistent so methods with "objects" in the name can
> accept/return objects and groups, and methods with "groups" in the
> name only accept/return groups.) As you said, it might be useful to
> have "objectsExcludingGroups" methods.
> If the changes look okay, I'll commit them!

Looks good. I'll let you commit these changes. Before doing so, just  
run the test suite by typing 'make test=yes && ukrun  
CoreObject.bundle', and verify that only three tests fail.
Thanks for this patch :-)

Not really related but I'd like to merge ETUTI implementation into  
EtoileFoundation, is this possible or not yet?… The last time I read  
ETUTI class, the code looked fine to me. iirc the only missing part  
was exposing ObjC type system as UTIs.

Cheers,
Quentin.
_______________________________________________
Etoile-dev mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-dev

Reply via email to