Hello Eric,

On Sun, May 24, 2009 at 02:58:26PM -0600, Eric Wasylishen wrote:
> I tried your patch on my system (debian, has a recent version of
> libmp4v2 where the header is mp4v2/mp4v2.h and uses the new tags api)
> but the condition:
> #if defined MP4V2_PROJECT_repo_rev && MP4V2_PROJECT_repo_rev >=  231
> was not satisfied, so TLMusicFile tried to use the old API.

The macros are defined in mp4v2/project.h which is generated on build
time. I'm currently using the 1.9.0 version from Christian Marillat's
debian-multimedia repository. The patch works with that version. 
Is that the version you are using or did you build from source (the
proper Debian repositories don't seem to have no libmp4v2)? Perhaps you
could let me know the contents of your project.h so we can find
something more reasonable to check for.

> I'm not sure what to do. It would be easiest just to require the new
> release of libmp4v2. Alternatively I could stop using libmp4v2 and
> rely on taglib - the next release should support mp4 (it does in SVN.)

I in my opinion, it would be desirable to drop libmp4v2 as soon as the
same functionality is available in taglib. This would reduce the number
of dependencies and would allow you to get rid of the mp4-specific code
in TLMusicFile.m someday. 

> As for your LanguageKit problem, if you use x86, have you already seen
> the note in LanguageKit/README about the LLVM patch currently needed
> on LLVM/x86?

If I understood David correctly, that patch is not needed on
64bit Linux, which is the platform I'm using. 

Cheers,


Niels

_______________________________________________
Etoile-dev mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-dev

Reply via email to