clockmenulet patch RC4

> From: [email protected]
> Date: Wed, 5 Jun 2013 15:13:46 +0100
> To: [email protected]
> Subject: Re: [Etoile-dev] EtoileMenuServer patch
> 
> On 5 Jun 2013, at 14:04, Slex Sangiuliano <[email protected]> wrote:
> 
> > patch RC3:
> > 
> > Index: ClockMenulet.h
> > ===================================================================
> > --- ClockMenulet.h        (revisione 8428)
> > +++ ClockMenulet.h        (copia locale)
> > @@ -23,6 +23,8 @@
> > 
> > #import <Foundation/NSObject.h>
> > #import "../../EtoileMenulet.h"
> > +#import <Foundation/NSCalendar.h>
> > +#import <Foundation/NSDateFormatter.h>
> 
> It might be better to include these in the .m and just put this in the header:
> 
> @class NSCalendar;
> @class NSDateFormatter;
> 
> > +      shortDayName = [[NSArray alloc] initWithArray:[dateFormatter 
> > shortWeekdaySymbols]];
> 
> This would be better as:
> 
> shortDayName = [[dateFormatter shortWeekdaySymbols] retain];
> 
> David
> 
> -- Sent from my STANTEC-ZEBRA
> 
> 
> _______________________________________________
> Etoile-dev mailing list
> [email protected]
> https://mail.gna.org/listinfo/etoile-dev
                                          

Attachment: clock_menulet_RC4.patch
Description: Binary data

_______________________________________________
Etoile-dev mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-dev

Reply via email to