Hi Andreas,

Thanks for the patches :-)

Le 11 sept. 06 à 16:23, Andreas Höschler a écrit :

NSMenuItemCell

        pico ./Bundles/Camaelon/NSMenuItemCell.m

I applied this one. Perhaps this was due to nil messaging not working well on Solaris?

NSBrowserCell

        pico ./Bundles/Camaelon/NSBrowserCell.m

- (void) drawInteriorWithFrame: (NSRect)cellFrame inView: (NSView *) controlView
{
  NSRect        title_rect = cellFrame;
  NSImage       *branch_image = nil;
  NSImage       *cell_image = nil;
  NSColor       *backColor;
  NSWindow      *cvWin = [controlView window];
  BOOL          showsFirstResponder;

//  if (!cvWin) return;

  if (_cell.is_highlighted || _cell.state)
    {
//     backColor = [self highlightColorInView: controlView];
     backColor = [NSColor selectedRowBackgroundColor]; // <---------

I removed the last line and implement -highlightColorInView: in the category. Otherwise I don't understand why backColor shouldn't be assigned a value here.

NSTableView
Comment out the setTexColor: lines to reenable - (void)tableView: (NSTableView *)tableView willDisplayCell:(id)cell forTableColumn: (NSTableColumn *)tableColumn object:(SOObject *)object.

I don't understand why calling -setTextColor prevents - willDisplayCell:blabla to be called. Can you describe the problem more precisely?
I think the necessary modification could be a different one.

NSColor
selectedRowBackgroundColor and selectedTextBackgroundColor should not be the same.

By reading, they don't seem to be the same. But even if they were the same, I think that shouldn't be a problem because I suppose selectedRowBackgroundColor is for tableview/browser/etc rows and textBackgroundColor is for the background color of controls like textfield when they have some text selected. I could be wrong on this point though.

I think Nicolas should be able to clarify how to handle the last two patches.

Thanks,
Quentin.

--
Quentin Mathé
[EMAIL PROTECTED]


_______________________________________________
Etoile-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-discuss

Répondre à