Hi Andreas,

I had a little look at the code and screenshot, and it looks  
promising.  A few minor things:

- It seems to be Linux-only.  Étoilé is a cross-platform project, and  
there is no abstraction layer between the Linux-specific code and the  
rest, which will make this very difficult to port to other  
platforms.  Take a look at Etoile/Services/Private/MenuServer/ 
Subprojects/AboutEtoileEntry/ETMachineInfo* for a clean way of doing  
this.  This class provides info about the amount of real memory and  
the CPU model / speed, and works on Linux, FreeBSD, OpenBSD, Darwin  
and Solaris.

- It seems like the battery reading code seems incredibly  
complicated.  On FreeBSD, reading the battery level just involves  
reading the hw.acpi.battery.life sysctl, and reading the number of  
minutes of life remaining just involves reading  
hw.acpi.battery.time.  Between them, these are about six lines of  
code.  Is Linux really so much more complicated?

- The code is GPL'd.  Since other components are liable to want to  
read the remaining battery life, the GPL is not going to work as a  
license for this kind of thing if you want it to go in the tree.  See  
here for a longer explanation of the licensing policy:
http://www.etoile-project.org/etoile/mediawiki/index.php? 
title=EtoileWiki:About

David

On 13 Sep 2007, at 19:59, Andreas Heppel wrote:

> Hi all,
> I have written a menulet for Etoile's menu server providing a  
> graphical feedback on a notebook's power state. It shows whether  
> the notebook is plugged in or whether it runs on battery and it  
> shows the battery fill state. The menulet will also notify you when  
> the battery goes below a critical level.
> You may download the archive at http://www.andreasheppel.de/ 
> software.html. You will also find a screenshot there.
>
> Thanks for your interest. Have fun :-)
>
> Andreas
> ______________________________________________________________________ 
> _
> Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 3 Monate
> kostenlos testen. http://www.pc-sicherheit.web.de/startseite/? 
> mc=022220
>
>
> _______________________________________________
> Etoile-discuss mailing list
> [email protected]
> https://mail.gna.org/listinfo/etoile-discuss


_______________________________________________
Etoile-discuss mailing list
[email protected]
https://mail.gna.org/listinfo/etoile-discuss

Répondre à