Thanks, Jane. +1 to eslint-disable for me. I'd also prefer to keep the lint output clear and usable for others.
-b On Fri, May 10, 2024 at 12:49 PM Jane Sandberg via Evergreen-dev < [email protected]> wrote: > The following one-line does it for me for ts files: > > for unlinted in $(npx ng lint | grep "eg2.*ts"); do echo "/* > eslint-disable */"|cat - $unlinted > /tmp/in-progress && mv > /tmp/in-progress $unlinted; done > > Bill -- yes, there is a <!-- eslint-disable -->. you can see it live > in src/app/staff/catalog/hold/hold.component.html, amongst others. > > El vie, 10 may 2024 a la(s) 9:24 a.m., Stephanie Leary via Evergreen-dev ( > [email protected]) escribió: > >> +1 to pausing for now. It is possible to lint a single directory at a >> time, so we should be able to isolate various projects and tackle them >> individually later. We know the issues came in on April 26, so that tells >> us where to start. >> >> Jane, my only objection to /* eslint-disable */ is that there are just so >> many files in Acq and Reports that it would be tedious to edit each one. >> >> >> Stephanie Leary >> Front End Developer >> Equinox Open Library Initiative >> [email protected] >> https://www.equinoxOLI.org >> phone: 877-OPEN-ILS (673-6457) >> >> >> On Fri, May 10, 2024 at 11:17 AM Jane Sandberg via Evergreen-dev < >> [email protected]> wrote: >> >>> My preference would be to put an /* eslint-disable */ at the top of the >>> relevant files, instead. It keeps the linter green, and is a clue to future >>> readers of the code "look out, there may be some unusual stuff in here, >>> lint-wise" >>> >>> I worry that if we get used to the linter failing, we will stop paying >>> attention to it. >>> >>> My $0.02, with appreciation to the release team. >>> >>> On Fri, May 10, 2024, 8:57 AM Mike Rylander via Evergreen-dev < >>> [email protected]> wrote: >>> >>>> +1 from me, for sure. >>>> >>>> Regards, >>>> >>>> Mike Rylander >>>> >>>> -- Sent from my phone, please pardon my thumbs. >>>> | Research and Development Manager >>>> | Equinox Open Library Initiative >>>> | phone: 1-877-OPEN-ILS (673-6457) >>>> | email: [email protected] >>>> | web: http://EquinoxInitiative.org >>>> >>>> On Fri, May 10, 2024, 11:49 AM Bill Erickson via Evergreen-dev < >>>> [email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> We're bumping against a lot of Angular lint errors on pending feature >>>>> branches as a result of relatively recent linting rules, some of which >>>>> will >>>>> require significant refactoring to resolve. >>>>> >>>>> Note that 'ng lint --fix' helps, but it only fixes certain classes of >>>>> errors, mostly cosmetic. >>>>> >>>>> These feature branches have been tested in the wild and are generally >>>>> ready to go. Efforts have been made to resolve the lint issues, but some >>>>> fixes, like batch changing "==" to "===" can cause problems, since the >>>>> original code was not created and tested with those assumptions in place. >>>>> Other more complicated issues could take days or longer to fix and >>>>> re-test. >>>>> >>>>> I propose we relax our requirement that merged code be fully cleared >>>>> of lint errors at merge time until we get through this phase of feature >>>>> merging. >>>>> >>>>> Thoughts? >>>>> >>>>> Thanks, >>>>> >>>>> -b >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Evergreen-dev mailing list >>>>> [email protected] >>>>> http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev >>>>> >>>> _______________________________________________ >>>> Evergreen-dev mailing list >>>> [email protected] >>>> http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev >>>> >>> _______________________________________________ >>> Evergreen-dev mailing list >>> [email protected] >>> http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev >>> >> _______________________________________________ >> Evergreen-dev mailing list >> [email protected] >> http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev >> > _______________________________________________ > Evergreen-dev mailing list > [email protected] > http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev >
_______________________________________________ Evergreen-dev mailing list [email protected] http://list.evergreen-ils.org/cgi-bin/mailman/listinfo/evergreen-dev
