On Fri, 2007-03-30 at 07:48 +0100, Karl Relton wrote: > Srini > > Welcome to your new role. Thanks you.
> I posted this on evolution-patches a couple of > weeks back, but don't think anyone has got round to it yet ... > > > Whilst looking at the code for other things, I think I have spotted a > bug in main_system_beep() in mail-session.c. You are absolutely right. It is a bug and the patch fixes it right. Just for tracking, file a bug and attach the patch to bugzilla (Pass us the bug id). It has to go for STABLE and trunk branches. -Srini. > > Comparing the beep function with play_sound function: > > session_play_sound() and main_play_sound() do a > camel_object_ref(session) and a camel_object_unref(session) between > them. > > However, session_system_beep() and main_system_beep() does the > camel_object_ref(session) but without the corresponding unref. > > I assume thats wrong - the patch below fixes that by putting in the > unref. > > Karl > > --- mail-session.c.old 2007-03-02 11:31:23.000000000 +0000 > +++ mail-session.c 2007-03-02 11:29:42.000000000 +0000 > @@ -441,6 +441,7 @@ static void > main_system_beep (CamelFilterDriver *driver, gpointer user_data) > { > gdk_beep (); > + camel_object_unref (session); > } > > static void > > > _______________________________________________ > Evolution-hackers mailing list > Evolution-hackers@gnome.org > http://mail.gnome.org/mailman/listinfo/evolution-hackers _______________________________________________ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers