I made a couple of changes to my ancient (2.28.4) version of evolution.
First, I encountered a nuisance in the alarm notify dialog, that when
the dialog pops up and a new alarm is coming in, the selection changes
to this new item, while the user potentially ist just clicking the
dismiss or snooze button. I made the attached change to simply not
preselect anything, having checked that the same is still running in the
current git version at https://git.gnome.org/browse/evolution.
I also had a crash in the alarm-notify app and I inserted the attached
safety check.
--
thomas
commit 20c497b8a7fa130eae9c639c191aa0821c1f8d47
Author: Thomas Mittelstaedt <tmsta...@t-mittelstaedt.de>
Date: Thu Aug 15 06:55:43 2013 +0200
Don't set selection to new items coming in while dialog is open
diff --git a/calendar/gui/alarm-notify/alarm-queue.c b/calendar/gui/alarm-notify/alarm-queue.c
index 5d9177d..9a3f80b 100644
--- a/calendar/gui/alarm-notify/alarm-queue.c
+++ b/calendar/gui/alarm-notify/alarm-queue.c
@@ -1306,7 +1306,7 @@ open_alarm_dialog (TrayIconData *tray_data)
tray_data->location,
notify_dialog_cb, tray_data);
- gtk_tree_selection_select_iter (selection, &tray_data->iter);
+ /* gtk_tree_selection_select_iter (selection, &tray_data->iter); */
}
commit 2d7f700f3ef7de943549f4780252c9c6bcf1fc68
Author: Thomas Mittelstaedt <tmsta...@t-mittelstaedt.de>
Date: Thu Aug 15 07:27:34 2013 +0200
Check for empty list in tray_list_remove_async
diff --git a/calendar/gui/alarm-notify/alarm-queue.c b/calendar/gui/alarm-notify/alarm-queue.c
index 9a3f80b..59a0884 100644
--- a/calendar/gui/alarm-notify/alarm-queue.c
+++ b/calendar/gui/alarm-notify/alarm-queue.c
@@ -1103,6 +1103,7 @@ static void
tray_list_remove_async (Message *msg)
{
GList *list = tray_icons_list;
+ g_return_if_fail (g_list_first(list) != NULL);
d(printf("%s:%d (tray_list_remove_async) - Removing %d alarms\n",__FILE__, __LINE__, g_list_length(list)));
while (list != NULL) {
_______________________________________________
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-hackers
