On 27 Apr 2001, Dan Winship wrote:
> > - if (-1 == camel_folder_summary_load (folder->summary)) {
> > - /* Bad or nonexistant summary file */
> > - camel_nntp_get_headers (CAMEL_FOLDER( folder )->parent_store,
> > - nntp_folder, ex);
> > - if (camel_exception_get_id (ex)) {
> > - camel_object_unref (CAMEL_OBJECT (folder));
> > - return NULL;
> > - }
> > -
> > - /* XXX check return value */
> > - camel_folder_summary_save (folder->summary);
> > + camel_folder_summary_load (folder->summary);
> > +
> > + /* Bad or nonexistant summary file */
> > + camel_nntp_get_headers (CAMEL_FOLDER( folder )->parent_store,
> > + nntp_folder, ex);
> > + if (camel_exception_get_id (ex)) {
> > + camel_object_unref (CAMEL_OBJECT (folder));
> > + return NULL;
>
> What's this about? You're loading the summary, and then whether it
> succeeded or not, you're loading the headers off the server as well.
>
> Hm... actually, could you add ChangeLog entries explaining the changes
> and then re-submit the patches with those?
Well, I modified camel_nntp_get headers as well... it only loads the
articles not covered by the summary, as well as expiring all articles in
the summary no longer on the nntp server. previously, if a summary file
existed, the nntp server would not be contacted... (only one batch of news
ever...)
-- Sam
(will update changelogs in later patches.... and what's the qualifying
criteria for CVS access 'round these parts?)
_______________________________________________
evolution-hackers maillist - [EMAIL PROTECTED]
http://lists.helixcode.com/mailman/listinfo/evolution-hackers
