[Evolution-hackers] The filter rule editor dialog crash when clicking add

[Mikael Hallendal]

Hi!

I've noticed that on my system (Gentoo, no not with -O3) when clicking
the OK button in the Rule Editor the mail component crashes. The applied
patch fixes the problem. Can I commit it (and if so, should it be
commited on HEAD?)

Regards,
  Mikael Hallendal

-- 
Mikael Hallendal                [EMAIL PROTECTED]
CodeFactory AB                  http://www.codefactory.se/
Office: +46 (0)8 587 583 05     Cell: +46 (0)709 718 918

Index: filter/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/filter/ChangeLog,v
retrieving revision 1.267
diff -u -r1.267 ChangeLog
--- filter/ChangeLog    2002/01/15 02:26:10     1.267
+++ filter/ChangeLog    2002/01/26 17:01:41
@@ -1,3 +1,9 @@
+2002-01-26  Mikael Hallendal  <[EMAIL PROTECTED]>
+
+       * rule-editor.c (add_editor_clicked): check if re->edit != NULL
+         before trying to unref it. Fixes a segfault when closing the 
+         rule editor.
+
 2002-01-15  Not Zed  <[EMAIL PROTECTED]>
 
        * filter-input.c (xml_decode): If we write "" to an xml file, we
Index: filter/rule-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/filter/rule-editor.c,v
retrieving revision 1.28
diff -u -r1.28 rule-editor.c
--- filter/rule-editor.c        2001/11/27 21:46:22     1.28
+++ filter/rule-editor.c        2002/01/26 17:01:41
@@ -253,7 +253,10 @@
        default:
                gnome_dialog_close (GNOME_DIALOG (dialog));
        case -1:
-               gtk_object_unref (GTK_OBJECT (re->edit));
+                if (re->edit) {
+                        gtk_object_unref (GTK_OBJECT (re->edit));
+                }
+                
                re->edit = NULL;
                
                re->dialog = NULL;

signature.asc
Description: PGP signature