I'd say "fine by me" Jeff
On Wed, 2002-04-17 at 11:30, Russell Steinthal wrote: > On Wed, 2002-04-17 at 11:02, Russell Steinthal wrote: > > On Wed, 2002-04-17 at 08:22, Not Zed wrote: > > > > Well what if they have a comment with a ' or " or | in it? What if they > > > accepted an appointment from someone else with such in its description? > > > > > > Its also not just a question of security, there's also just correct > > > operation. e.g. an embedded ' or " might cause the shell command to > > > fail, so the program wont actually get run. (e.g. description is "come > > > to nat's party!" - not sure if it will fail, but it something to look > > > at) > > > > Do you know if we already have a function (whether in glib, libgnome, > > e-util, etc.) to do this? It would seem to be a problem which is likely > > to have occurred in the past, and which it's good to get right once > > rather than multiple times... > > Following up to myself... > > Glib2 has g_shell_quote, which seems to be exactly what I'm looking > for. Since I assume Evolution isn't going to depend on glib2 for at > least a few versions, is there any objection to my doing a cut-and-paste > "port" to, say, e_shell_quote()? > > -- > Russell Steinthal Columbia Law School, Class of 2002 > <[EMAIL PROTECTED]> Columbia College, Class of 1999 > <[EMAIL PROTECTED]> UNIX System Administrator, nj.org > > _______________________________________________ > evolution-hackers maillist - [EMAIL PROTECTED] > http://lists.ximian.com/mailman/listinfo/evolution-hackers > -- Jeffrey Stedfast Evolution Hacker - Ximian, Inc. [EMAIL PROTECTED] - www.ximian.com _______________________________________________ evolution-hackers maillist - [EMAIL PROTECTED] http://lists.ximian.com/mailman/listinfo/evolution-hackers
