I just found the bug # for this:
http://bugzilla.ximian.com/show_bug.cgi?id=701
It'd be good if you could attach your patches to it (so that we don't
lose them)
I've reviewed the patch and it looks fine, just need a GUI now :-)
Jeff
On Sat, 2002-05-25 at 00:32, Jim Meyer wrote:
> Howdy!
>
> After a long, long time (with a big break in the middle) I've managed to
> put the back end of configurable reply attributions in place. It's
> largely useless to your average user at this point as there's no way
> short of a text editor and an ascii-to-hex encoder.
>
> This patch is made against EVOLUTION_1_0_5 in CVS; it will honor an
> identity_reply_attribution_# in ~/evolution/config.xmldb like so:
>
> <entry name="identity_reply_attribution_0" type="string"
> value="4f6e206f7220
> 61626f75742025483a254d206f6e2025612c2025642025622025592c20252573206372696564206f
> 75743a"/>
>
> Could this be accepted into the EVOLUTION_1_0_5 branch?
>
> Next ... a discussion of the UI for changing this. =]
>
> Cheers!
>
> --j
>
> On or about 17:03 on Thu, 15 Nov 2001, Jim Meyer cried out:
> > Howdy!
> >
> > I've been studying mail-config.[ch] with hopes of adding reply
> > attribution string customization. I think this attribute should be
> > allowed to vary across multiple mail accounts. This leads me to want to
> > make the reply attribution a gchar * in either MailConfigAccount or
> > MailConfigIdentity ... and I can make a good case for either.
> >
> > Opinions?
> >
> > Thanks!
> >
> > --j
> > --
> > Jim Meyer, Geek At Large [EMAIL PROTECTED]
>
> ____________________________________________________________________
>
> Index: mail-callbacks.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/mail-callbacks.c,v
> retrieving revision 1.282.4.7
> diff -U4 -r1.282.4.7 mail-callbacks.c
> --- mail-callbacks.c 18 Apr 2002 20:45:18 -0000 1.282.4.7
> +++ mail-callbacks.c 25 May 2002 03:53:43 -0000
> @@ -830,28 +830,8 @@
>
> if (!composer)
> return NULL;
>
> - sender = camel_mime_message_get_from (message);
> - if (sender != NULL && camel_address_length (CAMEL_ADDRESS (sender)) > 0) {
> - camel_internet_address_get (sender, 0, &name, &address);
> - } else {
> - name = _("an unknown sender");
> - }
> -
> - date = camel_mime_message_get_date (message, NULL);
> -
> - strftime (date_str, sizeof (date_str), _("On %a, %Y-%m-%d at %H:%M, %%s
>wrote:"),
> - localtime (&date));
> - format = e_utf8_from_locale_string (date_str);
> - text = mail_tool_quote_message (message, format, name && *name ? name :
>address);
> - g_free (format);
> -
> - if (text) {
> - e_msg_composer_set_body_text (composer, text);
> - g_free (text);
> - }
> -
> /* Set the recipients */
> accounts = mail_config_get_accounts ();
>
> to_addrs = camel_mime_message_get_recipients (message,
>CAMEL_RECIPIENT_TYPE_TO);
> @@ -991,8 +971,29 @@
> e_msg_composer_add_header (composer, "References", reply_refs);
> g_free (reply_refs);
> } else if (references) {
> e_msg_composer_add_header (composer, "References", references);
> + }
> +
> + /* Finally, add reply attribution and quoted reply */
> + sender = camel_mime_message_get_from (message);
> + if (sender != NULL && camel_address_length (CAMEL_ADDRESS (sender)) > 0) {
> + camel_internet_address_get (sender, 0, &name, &address);
> + } else {
> + name = _("an unknown sender");
> + }
> +
> + date = camel_mime_message_get_date (message, NULL);
> +
> + strftime (date_str, sizeof (date_str), _(me->id->reply_attribution),
> + localtime (&date));
> + format = e_utf8_from_locale_string (date_str);
> + text = mail_tool_quote_message (message, format, name && *name ? name :
>address);
> + g_free (format);
> +
> + if (text) {
> + e_msg_composer_set_body_text (composer, text);
> + g_free (text);
> }
>
> return composer;
> }
> Index: mail-config.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/mail-config.c,v
> retrieving revision 1.187.4.3
> diff -U4 -r1.187.4.3 mail-config.c
> --- mail-config.c 2001/12/14 20:01:30 1.187.4.3
> +++ mail-config.c 2002/05/25 03:53:49
> @@ -420,8 +420,12 @@
> path = g_strdup_printf
>("/Mail/Accounts/identity_has_html_signature_%d", i);
> id->has_html_signature = bonobo_config_get_boolean_with_default (
> config->db, path, FALSE, NULL);
> g_free (path);
> + path = g_strdup_printf
>("/Mail/Accounts/identity_reply_attribution_%d", i);
> + id->reply_attribution = bonobo_config_get_string_with_default
>(config->db, path, "On %a, %Y-%m-%d at %H:%M, %%s wrote:", NULL);
> + g_warning ("ID %d reply_attribution == %s", i, id->reply_attribution);
> + g_free (path);
>
> /* get the source */
> source = g_new0 (MailConfigService, 1);
>
> @@ -716,8 +720,12 @@
> g_free (path);
>
> path = g_strdup_printf
>("/Mail/Accounts/identity_has_html_signature_%d", i);
> bonobo_config_set_boolean (config->db, path,
>account->id->has_html_signature, NULL);
> + g_free (path);
> +
> + path = g_strdup_printf
>("/Mail/Accounts/identity_reply_attribution_%d", i);
> + bonobo_config_set_string (config->db, path,
>account->id->reply_attribution, NULL);
> g_free (path);
>
> /* source info */
> path = g_strdup_printf ("/Mail/Accounts/source_url_%d", i);
> Index: mail-config.h
> ===================================================================
> RCS file: /cvs/gnome/evolution/mail/mail-config.h,v
> retrieving revision 1.69
> diff -U4 -r1.69 mail-config.h
> --- mail-config.h 8 Nov 2001 22:31:53 -0000 1.69
> +++ mail-config.h 25 May 2002 03:53:52 -0000
> @@ -36,8 +36,9 @@
> gchar *address;
> gchar *organization;
> gchar *signature;
> gchar *html_signature;
> + gchar *reply_attribution;
> gboolean has_html_signature;
> } MailConfigIdentity;
>
> typedef struct {
_______________________________________________
evolution-hackers maillist - [EMAIL PROTECTED]
http://lists.ximian.com/mailman/listinfo/evolution-hackers
