Hi ! This mail doesn't display a 'To: ...' header in the previw pane Xav
Hi, Please consider applying. - Arnaldo --- linux-2.4.5-ac21/drivers/sbus/char/sab82532.c Fri Jun 29 10:57:25 2001 +++ linux-2.4.5-ac21.acme/drivers/sbus/char/sab82532.c Fri Jun 29 14:49:37 2001 @@ -1368,12 +1368,10 @@ static int set_modem_info(struct sab82532 * info, unsigned int cmd, unsigned int *value) { - int error; unsigned int arg; - error = get_user(arg, value); - if (error) - return error; + if (get_user(arg, value)) + return -EFAULT; switch (cmd) { case TIOCMBIS: if (arg & TIOCM_RTS) { @@ -1442,7 +1440,6 @@ static int sab82532_ioctl(struct tty_struct *tty, struct file * file, unsigned int cmd, unsigned long arg) { - int error; struct sab82532 * info = (struct sab82532 *)tty->driver_data; struct async_icount cprev, cnow; /* kernel counter temps */ struct serial_icounter_struct *p_cuser; /* user space */ @@ -1462,9 +1459,8 @@ case TIOCGSOFTCAR: return put_user(C_CLOCAL(tty) ? 1 : 0, (int *) arg); case TIOCSSOFTCAR: - error = get_user(arg, (unsigned int *) arg); - if (error) - return error; + if (get_user(arg, (unsigned int *) arg)) + return -EFAULT; tty->termios->c_cflag = ((tty->termios->c_cflag & ~CLOCAL) | (arg ? CLOCAL : 0)); @@ -1534,14 +1530,11 @@ cnow = info->icount; sti(); p_cuser = (struct serial_icounter_struct *) arg; - error = put_user(cnow.cts, &p_cuser->cts); - if (error) return error; - error = put_user(cnow.dsr, &p_cuser->dsr); - if (error) return error; - error = put_user(cnow.rng, &p_cuser->rng); - if (error) return error; - error = put_user(cnow.dcd, &p_cuser->dcd); - if (error) return error; + if (put_user(cnow.cts, &p_cuser->cts) || + put_user(cnow.dsr, &p_cuser->dsr) || + put_user(cnow.rng, &p_cuser->rng) || + put_user(cnow.dcd, &p_cuser->dcd)) + return -EFAULT; return 0; default: _______________________________________________ Kernel-janitor-discuss mailing list [EMAIL PROTECTED] http://lists.sourceforge.net/lists/listinfo/kernel-janitor-discuss