On Thu, Sep 10, 2009 at 11:18:43AM -0500, Jon Mason wrote:
> On Thu, Sep 10, 2009 at 06:11:48PM +0200, Alexander Schmidt wrote:
> > On Thu, 10 Sep 2009 11:41:10 +0300
> > Tziporet Koren <tzipo...@dev.mellanox.co.il> wrote:
> > 
> > > Alexander Schmidt wrote:
> > > > On Wed, 9 Sep 2009 16:47:14 +0300
> > > > "Tziporet Koren" <tzipo...@mellanox.co.il> wrote:
> > > > Hi,
> > > >
> > > >   
> > > >> Hi,
> > > >> I wish to update all that we plan to release OFED 1.5 beta tomorrow
> > > >>
> > > >> I know it's a week late then what we planned but we waited that all
> > > >> modules will at least pass compilation on all supported OSes before we
> > > >> publish the beta
> > > >>     
> > > >
> > > > the mthca driver does not compile yet on SLES11 on powerpc. I've already
> > > > reported this twice.
> > > >
> > > > -I/usr/src/linux-2.6.27.23-0.1/arch/powerpc/include \
> > > >  -Iarch/powerpc  
> > > > -I/var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca 
> > > > -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing 
> > > > -fno-common -Werror-implicit-function-declaration -fwrapv -Os 
> > > > -msoft-float -pipe -I/usr/src/linux-2.6.27.23-0.1/arch/powerpc 
> > > > -Iarch/powerpc -mminimal-toc -mtraceback=none -mcall-aixdesc 
> > > > -mcpu=power4 -mtune=cell -mno-altivec -mno-spe -funit-at-a-time 
> > > > -mno-string -Wa,-maltivec -fno-stack-protector -fomit-frame-pointer -g 
> > > > -Wdeclaration-after-statement -Wno-pointer-sign -fwrapv -DMODULE 
> > > > -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(mthca_eq)"  
> > > > -D"KBUILD_MODNAME=KBUILD_STR(ib_mthca)" -D"DEBUG_HASH=48" 
> > > > -D"DEBUG_HASH2=63" -c -o 
> > > > /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca/.tmp_mthca_eq.o
> > > >  
> > > > /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca/mthca_eq.c
> > > > In file included from 
> > > > /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/kernel_addons/backport/2.6.27_sles11/include/linux/cpumask.h:6,
> > > >                  from 
> > > > /usr/src/linux-2.6.27.23-0.1/include/linux/interrupt.h:9,
> > > >                  from 
> > > > /var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca/mthca_eq.c:35:
> > > > include2/asm/topology.h:75: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
> > > > ‘__attribute__’ before ‘dump_numa_cpu_topology’
> > > > make[6]: *** 
> > > > [/var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca/mthca_eq.o]
> > > >  Error 1
> > > > make[5]: *** 
> > > > [/var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband/hw/mthca] 
> > > > Error 2
> > > > make[4]: *** 
> > > > [/var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5/drivers/infiniband] Error 2
> > > > make[3]: *** [_module_/var/tmp/OFED_topdir/BUILD/ofa_kernel-1.5] Error 2
> > > > make[2]: *** [sub-make] Error 2
> > > > make[1]: *** [all] Error 2
> > > > make[1]: Leaving directory 
> > > > `/usr/src/linux-2.6.27.23-0.1-obj/ppc64/ppc64'
> > > > make: *** [kernel] Error 2
> > > > error: Bad exit status from /var/tmp/rpm-tmp.19962 (%build)
> > > >
> > > >   
> > > 
> > > Sorry we missed this
> > > I will put this limitation in the release mail and Jack will fix it soon
> > > 
> > > Tziporet
> > 
> > The following change fixes the issue for me, and it did not break other 
> > parts of
> > the stack, could someone review this?
> > 
> > Thanks
> > 
> > Index: 
> > ofa_kernel-1.5/kernel_addons/backport/2.6.27_sles11/include/linux/cpumask.h
> > ===================================================================
> > --- 
> > ofa_kernel-1.5.orig/kernel_addons/backport/2.6.27_sles11/include/linux/cpumask.h
> > +++ 
> > ofa_kernel-1.5/kernel_addons/backport/2.6.27_sles11/include/linux/cpumask.h
> > @@ -3,7 +3,6 @@
> >  
> >  #include_next <linux/cpumask.h>
> >  #include <asm/percpu.h>
> > -#include <asm/topology.h>
> >  
> >  #define cpumask_of(cpu)            (get_cpu_mask(cpu))
> >  #define cpumask_of_node(node) (_node_to_cpumask_ptr(node))
> 
> I believe this will break compilation on x86_64, but I will verify.

It seems to compile fine, go ahead and commit it.

Thanks,
Jon

> 
> > 
> > _______________________________________________
> > ewg mailing list
> > ewg@lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
> _______________________________________________
> ewg mailing list
> ewg@lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg
_______________________________________________
ewg mailing list
ewg@lists.openfabrics.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

Reply via email to