https://bugs.exim.org/show_bug.cgi?id=3071

--- Comment #10 from [email protected] ---
(In reply to Jeremy Harris from comment #9)
> (In reply to exim-bugs from comment #8)
> >     control = cutthrough_delivery/defer=pass,sender=transport
> 
> Incorrect syntax: Multiple options need to be separated by / not ,

Good.

As for DKIM, I have dkim_domain option, but it expands to empty string.

Should src/verify.c check whether dkim_domain is empty?

  1124       /* DKIM signing needs to add a header after seeing the whole body,
so we cannot just c
opy
   1125       body bytes to the outbound as they are received, which is the
intent of cutthrough. */
   1126       if (ob->dkim.dkim_domain)
   1127         {
   1128         cutthrough.delivery= FALSE;
   1129         HDEBUG(D_acl|D_v) debug_printf("Cutthrough cancelled by
presence of DKIM signing\n")
;
   1130         }

Maybe use something like miscmods/dkim.c:

    928 if (dkim_domain)
    929   while ((dkim_signing_domain = string_nextinlist(&dkim_domain, &sep,
NULL, 0)))
    930   {
    931   const uschar * dkim_sel;
    932   int sel_sep = 0;
    933
    934   if (dkim_signing_domain[0] == '\0')
    935     continue;

Actually docs state that DKIM signing does not happen if dkim_domain,
dkim_selector or dkim_private_key is empty, so all those should be checked.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

-- 
## subscription configuration (requires account):
##   https://lists.exim.org/mailman3/postorius/lists/exim-dev.lists.exim.org/
## unsubscribe (doesn't require an account):
##   [email protected]
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

Reply via email to