On 29/08/14 13:26, Jeremy Harris wrote:
> On 29/08/14 08:22, Warren Baker wrote:
>> On Thu, Aug 28, 2014 at 11:48 AM, John Horne <john.ho...@plymouth.ac.uk> 
>> wrote:
>>> We have just updated our mail servers to Exim 4.84, and we are now
>>> seeing segfault errors on two (of three) servers:
> [...]
>> Yeah likewise - I have debugging but not enough (so will dig deeper).
> We've not settled on this yet, but for people being bitten by this
> and not minding a recompile:
>
> src/mime.c  about line 600:
>
> replace
>   uschar *param_value = NULL;
> with
>   uschar *param_value = string_copy(US"");
>
This didn't work for me. The attached patch seems OK so far...

Cheers
David
--- mime.c	2014-08-09 13:44:29.000000000 +0100
+++ mime.c.new	2014-09-01 07:41:50.000000000 +0100
@@ -597,15 +597,16 @@
 	       mp < &mime_parameter_list[mime_parameter_list_size];
 	       mp++)
 	    {
-	    uschar *param_value = NULL;
-	    int param_value_len = 0;
-
 	    /* found an interesting parameter? */
 	    if (strncmpic(mp->name, p, mp->namelen) == 0)
 	      {
 	      uschar *q = p + mp->namelen;
 	      int size = 0;
 	      int ptr = 0;
+	      uschar *param_value = NULL;
+	      int param_value_len = 0;
+
+	      param_value = string_cat(param_value, &size, &ptr, NULL, 0);
 
 	      /* yes, grab the value and copy to its corresponding expansion variable */
 	      while(*q && *q != ';')		/* ; terminates */
-- 
## List details at https://lists.exim.org/mailman/listinfo/exim-users
## Exim details at http://www.exim.org/
## Please use the Wiki with this list - http://wiki.exim.org/

Reply via email to