Ruben Great - I have it working, and no crashes (so far ...).
A few thoughts/questions: - Adjust Colors - Why have Brightness as a decimal number? If its range is -100 to 100, surely an integer would suffice for us. That would have a side effect of neatening the fields in the gui! - Similarly for brightness - why not make that -100 to +100 rather than -1.00 to 1.00. Then at least saturation, brightness and contrast are all unified as -100 to 100, leaving just Exposure and Hue different. (I understand Hue being -180 to 180, but not sure about Exposure being -4.0 to 4.0 though !). - While we are at it, the ranges on Temp and Tint ... do they mean anything? - Its now auto-switching the Sidebar, but if the Sidebar is not being displayed at all, then currently the user has to remember to turn on the Sidebar again. I think it would be better to always auto-turn-on the Sidebar when going into Edit mode. - Surely we can now move Edit->Sharpen from the top menu to the Edit Sidebar? - Back to the question of 'Undo' (or at least providing a confirm). How about make the provision of Confirm/Cancel buttons a user preference for the current instant-apply operations (like Sepia). That way an experienced user can go to preferences and get his/her one-click workflow, but playing safe for the rest of us mere mortals. Good work - we are clearly into 'tidy up' now on this. Karl On Wed, 2008-08-27 at 16:35 +0200, Ruben Vermeersch wrote: > Hi Karl, > > It's in trunk now, so there's no need to apply any patches anymore. > Enjoy! > > On di, 2008-08-26 at 19:25 +0100, Karl Relton wrote: > > Hi Ruben > > > > I'm back off holiday and tried to give this a go. I've got a bit un-stuck, > > because > > svn has moved on since you did the patch. I've hacked it to apply - but in > > so doing > > seem to have lost the crop functionality. > > > > Whats the status your end? > > > > Karl > > > > > Hi all! > > > > > > I have just put the next version of the sidebar editors patch online. > > > It > > > contains fixes / enhancements for the issues brought up by the initial > > > testing. This is the one I want to merge to trunk. > > > > > > You can find it over here: > > > http://files.savanne.be/linux/patches/f-spot/f-spot-sidebar-editors.patch > > > > > > What remains to be done: > > > * Cosmetics > > > * Porting the AutoColor editor > > > * Hopefully not too many bugfixes > > > > > > These last few tasks will follow in additional patches. > > > > > > Comments welcome! > > > Ruben > > > > > > > -- > Ruben Vermeersch (rubenv) > http://www.savanne.be > > _______________________________________________ F-spot-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/f-spot-list
