Hi Daniel -

I used libs/xml to parse the darcs changelog[1]. Notice how in the  
output, the string stored inside the 'author' attribute of each tag  
is boxed inside an array. That's a bit odd, is that a bug? I Think  
tag-props should be a mapping from 'name' tuples to strings, not 1- 
element arrays of strings.

Also the prop-name word is awkward, it does a linear scan through a  
hashtable. If you must linear search, you should use an association  
list represented as a vector of pairs (use push to add new props).

Finally the naming could be improved in places:

children-tags ==> child-tags
get-name-tag ==> tag-named
get-name-tags ==> tags-named
prop-name ==> tag-prop

Finally if you run demos/contributors, you'll see that it is a bit  
slow. 'darcs changes --xml-output' produces > 500kb of XML. Factor's  
I/O is slow right now and I'm going to work on improving that really  
soon now, but perhaps there are optimizations which can be performed  
on libs/xml itself.

Slava

[1] http://factor-language.blogspot.com/2007/01/tool-to-tally- 
contributor-patch-counts.html

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Factor-talk mailing list
Factor-talk@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/factor-talk

Reply via email to