Fixed. It's a crufty edge-case because the RFC says whitespace is significant which makes parsing easy, but in practice lots of csv files contain space padding between non-quoted fields that needs trimming e.g.: foo, bah, baz Unfortunately leading spaces in quotes were also getting trimmed so now quoted fields handle whitespace separately to unquoted ones.
Sorry for the hassle, I've learnt my lesson about run-tests! Phil Phil Dawes wrote: > Ah no, the problem was me misunderstanding how the run-tests word works. > I assumed if it printed no errors that that was all cool. D'oh! > > Phil Dawes wrote: >> Sorry about that - probably happened after the rebasing as I didn't >> think to re-run the tests. Will get it fixed in my lunch break. >> >> Apologies, >> >> Phil >> >> Slava Pestov wrote: >>> Hi Phil, >>> >>> I had to fix a couple of things in csv-tests.factor (missing IN:, >>> and one unit-test should have been named-unit-test) but there's a >>> failing unit test. >>> >>> Can you please fix this? No binary packages can be uploaded as long >>> as tests fail. >>> >>> Slava >>> >>> ------------------------------------------------------------------------- >>> >>> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference >>> Don't miss this year's exciting event. There's still time to save >>> $100. Use priority code J8TL2D2. >>> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone >>> >>> >>> _______________________________________________ >>> Factor-talk mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/factor-talk >>> >> >> > > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Factor-talk mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/factor-talk
