Hi! The README says
: If you are using gcc 4.3, you might get an unusable Factor binary unless
: you add 'SITE_CFLAGS=-fno-forward-propagate' to the command-line
: arguments for make.
This is something one shouldn't necessarily need to be aware of -- given
that build and update related tasks are managed via factor.sh...
So why not make the script aware of this gotcha? I'm sending a patch which
just does this.
[Yes, I've read Factor FAQ Q/A 51, but setting up a git repo for such a
small change seems to be an overkill to me. I hope that inlining the
patch into this mail is OK with you.]
Regards,
Csaba
------------------8<-----------[patch from here to end]----------
diff --git a/build-support/factor.sh b/build-support/factor.sh
index 5cbc1e9..cadb2ef 100755
--- a/build-support/factor.sh
+++ b/build-support/factor.sh
@@ -65,6 +65,9 @@ check_gcc_version() {
$ECHO "Install gcc 3.4 or higher and try again."
exit 3
fi
+ if [[ $GCC_VERSION == *4.3.* ]] ; then
+ MAKE_OPTS="$MAKE_OPTS SITE_CFLAGS=-fno-forward-propagate"
+ fi
$ECHO "ok."
}
@@ -335,7 +338,7 @@ cd_factor() {
}
invoke_make() {
- $MAKE $*
+ $MAKE $MAKE_OPTS $*
check_ret $MAKE
}
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Factor-talk mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/factor-talk
