Great. One last thing: write unit tests for the test parsers so we have an automated way to see if they work, and just move the test parsers to peg-lexer-tests.factor. (Once this is done, you can run your unit tests with "peg-lexer" test; this is very convenient for interactive development, I find.) Then I'll pull from you.
Dan On Tue, Mar 10, 2009 at 6:36 PM, Sam Anklesaria <anklesa...@gmail.com> wrote: > Documentation, summary, authors, and tags have all been updated. > > Daniel Ehrenberg wrote: >> This looks great! Good work. >> >> To get stuff committed to the repository, you just have to ask one of >> the core developers with commit access to pull from you. I could do >> this. But, before that happens, there are a couple changes you should >> make to your code. First, this code should be in extra rather than >> basis. Second, it'd be nice if you documented the code and wrote unit >> tests for it. Third, you should make summary.txt and authors.txt >> files. Then, we can pull this into the Factor repository. >> >> Dan >> >> On Mon, Mar 9, 2009 at 8:52 PM, Sam Anklesaria <anklesa...@gmail.com> wrote: >>> I recently made a library that allows a peg parser to temporarily take over >>> the >>> lexer, which can be useful for implementing more complicated parsing words. >>> It's on github at http://github.com/bogiebro/factor/tree/master (called >>> peg-lexer) >>> >>> How would I commit this to Factor's repository? >>> >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Factor-talk mailing list >>> Factor-talk@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/factor-talk >>> >> >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Factor-talk mailing list >> Factor-talk@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/factor-talk >> > > > ------------------------------------------------------------------------------ > Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are > powering Web 2.0 with engaging, cross-platform capabilities. Quickly and > easily build your RIAs with Flex Builder, the Eclipse(TM)based development > software that enables intelligent coding and step-through debugging. > Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com > _______________________________________________ > Factor-talk mailing list > Factor-talk@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/factor-talk > ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Factor-talk mailing list Factor-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/factor-talk
