Thanks for the fixes, Anton. It sounds like the code is ready to merge now. I'll test it out and let you know how it goes.
Slava On Thu, Jan 27, 2011 at 12:26 PM, Anton Gorenko <ex.rzr...@gmail.com> wrote: > Hi Slava, > > 2010/12/21 Slava Pestov <sl...@factorcode.org>: >> Hi Anton, >> >> Sorry for the late reply; the code looks almost ready to merge. Some >> comments: >> >> - It needs an update for recent changes to alien.c-types. '<int>' is >> 'int <ref>', and '*int' is 'int deref', same for void*. > Done. > >> - Button presses still don't send the right events on 32-bit > Fixed (just stupid typo). > >> - The I/O code should be split off from ui.backend.gtk into >> ui.bakend.gtk.io or similar, and only loaded if the io.backend.unix >> vocabulary is present. Otherwise, you are always pulling in >> io.backend.unix.multiplexers and all dependencies. > Done. Also I splitted off ui.backend.input-methods.editors for the > same reason (ui.gadgets.editors has too many dependencies). > >> - Wheel scrolling is too slow - this is because you must set the >> scroll-direction global variable to indicate the acceleration in each >> component, not just -1/0/1. > It seems that it's impossible to find out the acceleration. > http://library.gnome.org/devel/gdk/unstable/gdk3-Event-Structures.html#GdkEventScroll > >> - Some of the deploy tests fail because the final image is too big. >> Factoring out the io.backend.unix dependency should fix this > There are 2 places where we can decrease size of the deployed image: > - stripping gobject-introspection.types:type-infos global variable in > tools.deploy.shaker = up to 500kB on 64-bit. > - xml.errors and xml.traversal use debugger (unnecessary) and > prettyprint (actually used in xml.errors for creating errors' > summaries) - no more *.prettyprint, *.debugger, etc. vocabs in > vocab-manifest-hello-ui = up to 200 kB on 64-bit. > So, after these fixes I got 1624112 bytes image (with x11 - 1596944 bytes). > >> - benchmark.ui-panes fails when deployed and run > Deploys and runs on 64-bit, I will check it on 32-bit. > > Anton > >> Slava >> >> ------------------------------------------------------------------------------ >> Lotusphere 2011 >> Register now for Lotusphere 2011 and learn how >> to connect the dots, take your collaborative environment >> to the next level, and enter the era of Social Business. >> http://p.sf.net/sfu/lotusphere-d2d >> _______________________________________________ >> Factor-talk mailing list >> Factor-talk@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/factor-talk >> > > ------------------------------------------------------------------------------ > Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! > Finally, a world-class log management solution at an even better price-free! > Download using promo code Free_Logger_4_Dev2Dev. Offer expires > February 28th, so secure your free ArcSight Logger TODAY! > http://p.sf.net/sfu/arcsight-sfd2d > _______________________________________________ > Factor-talk mailing list > Factor-talk@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/factor-talk > ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Factor-talk mailing list Factor-talk@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/factor-talk
