Hey Sean, The main reason I asked for contributors to get in touch with us first was because I wasn't sure how we were going to handle pull requests: who would review them, acceptance criteria, giving feedback to contributors in a timely manner, etc. I didn't want to leave contributors wondering when their pull requests will be handled.
It turns out that the problem is not delays in responding to pull requests, but in deciding what should be accepted and what shouldn't. We're starting to have that discussion at Daemon now. We're being fairly loose at the moment however you should expect our pull request acceptance policy to tighten over time. You shouldn't have to worry about this for now: as Geoff says, just submit pull requests as normal and if we have questions about it we'll add comments to your request. One thing that isn't obvious in the Github pull request guidelines is that pull requests should be issued from a dedicated topic branch. Pushing commits into your fork's trunk or maintenance branches for a pull request can cause problems for you if you later pull that branch from upstream. If you do this and push the updated branch back to your fork, it will mess up your pull request and we will have to reject it. Regards, Dennis On 30 October 2013 02:17, Sean Coyne <[email protected]> wrote: > Good to know, I was just commenting on Denis' request to let you know > ahead of time so we could be briefed on your process. > > I still think a readme explaining that you welcome contributions and > certainly mentioning the copyright language would be helpful, especially > given Github's automatic rendering of readme files and how they act as a > pseudo-"home page" for the repository. Might help introduce the framework > to new users exploring. > > Just my two cents. > > > On Monday, October 28, 2013 10:48:56 PM UTC-4, Geoff Bowers wrote: > >> Sean, >> >> On 23 October 2013 00:09, Sean Coyne <[email protected]> wrote: >> >>> Might I suggest adding a README explaining the process for pull >>> requests? Might help encourage others to provide bug fixes and >>> enhancements. >>> >> >> I don't believe there's any specific procedure beyond github's standard >> recommendations: >> >> https://help.github.com/**articles/using-pull-requests<https://help.github.com/articles/using-pull-requests> >> >> The only caveat is that all submissions must continue to cede copyright >> to "Daemon Pty Limited", the corporate custodian of the code base. >> >> Simple "pulls" will go through almost immediately. More complex stuff >> might spark a bit of discussion on the pull request itself, prior to going >> into the code base. >> >> Fork now! Pull at will ;) >> >> GB >> > -- > You received this message cos you are subscribed to "farcry-dev" Google > group. > To post, email: [email protected] > To unsubscribe, email: [email protected] > For more options: http://groups.google.com/group/farcry-dev > -------------------------------- > Follow us on Twitter: http://twitter.com/farcry > --- > You received this message because you are subscribed to the Google Groups > "farcry-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- Dennis Clark | Developer | Daemon | +61 2 8999 8872 | http://www.daemon.com.au -- You received this message cos you are subscribed to "farcry-dev" Google group. To post, email: [email protected] To unsubscribe, email: [email protected] For more options: http://groups.google.com/group/farcry-dev -------------------------------- Follow us on Twitter: http://twitter.com/farcry --- You received this message because you are subscribed to the Google Groups "farcry-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
