Hi, Dominique,
Thanks for the bug fix. It will be in the next SVN revision a little
later today.
John
On 3/1/12 2:16 PM, Dominique Prunier wrote:
> Hi John,
>
>
>
> I’m finally back working on my FastBit project. I noticed a small bug
> in r474. The short path in ibis::column::selectValuesT when selecting
> all values doesn’t return what the function is supposed to (error code
> instead of value count), which makes ibis::column::selectStringsfail
> (i discovered it trying to call fastbit_get_qualified_strings on a
> LONG column). This tiny patch seems to fix the issue:
>
>
>
> index b6100d3..1fec263 100644
>
> --- a/src/column.cpp
>
> +++ b/src/column.cpp
>
> @@ -4210,7 +4210,7 @@ long ibis::column::selectValuesT(const char* dfn,
>
> else
>
> ierr = getValuesArray(&vals);
>
>
>
> - return ierr;
>
> + return ierr == 0 ? vals.size() : -1;
>
> }
>
>
>
> try {
>
>
>
> Thanks,
>
>
>
> */Dominique Prunier/**//*
>
> APG Lead Developper
>
> Logo-W4N-100dpi
>
> 4388, rue Saint-Denis
>
> Bureau 309
>
> Montreal (Quebec) H2J 2L1
>
> Tel. +1 514-842-6767 x310
>
> Fax +1 514-842-3989
>
> [email protected] <mailto:[email protected]>
>
> www.watch4net.com <http://www.watch4net.com/>
>
> / /
>
> /This message is for the designated recipient only and may contain
> privileged, proprietary, or otherwise private information. If you have
> received it in error, please notify the sender immediately and delete
> the original. Any other use of this electronic mail by you is prohibited.
>
> //Ce message est pour le récipiendaire désigné seulement et peut
> contenir des informations privilégiées, propriétaires ou autrement
> privées. Si vous l'avez reçu par erreur, S.V.P. avisez l'expéditeur
> immédiatement et effacez l'original. Toute autre utilisation de ce
> courrier électronique par vous est prohibée.///
>
>
>
>
>
> _______________________________________________
> FastBit-users mailing list
> [email protected]
> https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
_______________________________________________
FastBit-users mailing list
[email protected]
https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
