Hi, Dominique,
Thanks for the patch. You are right that existing implementation for
the special case is wrong, but there might be a way to keep the
special case and get a quicker solution than use the general case. I
will give it a try in a minute.
John
On 3/22/12 4:23 PM, Dominique Prunier wrote:
> Quick patch to fix it:
>
>
>
> diff --git a/src/category.cpp b/src/category.cpp
>
> index 48176d3..770f49e 100644
>
> --- a/src/category.cpp
>
> +++ b/src/category.cpp
>
> @@ -463,9 +463,6 @@ long ibis::category::stringSearch(const char* str,
>
> getNullMask(hits); // mask = 0 if null
>
> hits.flip();
>
> }
>
> - else if (ind == 1 && dic.size() == 1) { // special case with one
> value
>
> - hits.set(1, thePart->nRows()); // every record has this value
>
> - }
>
> else if (ind <= dic.size()) { // found it in the dictionary
>
> indexLock lock(this, "category::stringSearch");
>
> if (idx != 0) {
>
>
>
> Thanks,
>
>
>
> */Dominique Prunier/**//*
>
> APG Lead Developper
>
> Logo-W4N-100dpi
>
> 4388, rue Saint-Denis
>
> Bureau 309
>
> Montreal (Quebec) H2J 2L1
>
> Tel. +1 514-842-6767 x310
>
> Fax +1 514-842-3989
>
> [email protected] <mailto:[email protected]>
>
> www.watch4net.com <http://www.watch4net.com/>
>
> / /
>
> /This message is for the designated recipient only and may contain
> privileged, proprietary, or otherwise private information. If you have
> received it in error, please notify the sender immediately and delete
> the original. Any other use of this electronic mail by you is prohibited.
>
> //Ce message est pour le récipiendaire désigné seulement et peut
> contenir des informations privilégiées, propriétaires ou autrement
> privées. Si vous l'avez reçu par erreur, S.V.P. avisez l'expéditeur
> immédiatement et effacez l'original. Toute autre utilisation de ce
> courrier électronique par vous est prohibée.///
>
>
>
>
>
> _______________________________________________
> FastBit-users mailing list
> [email protected]
> https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
_______________________________________________
FastBit-users mailing list
[email protected]
https://hpcrdm.lbl.gov/cgi-bin/mailman/listinfo/fastbit-users
