Hi Vivek!
On 3/28/07, Vivek Goyal <[EMAIL PROTECTED]> wrote:
> On Wed, Mar 28, 2007 at 01:37:31PM +0900, Magnus Damm wrote:
> > --- 0001/kexec/arch/ia64/crashdump-ia64.c
> > +++ work/kexec/arch/ia64/crashdump-ia64.c 2007-03-28 13:05:21.000000000
> > +0900
> > @@ -224,7 +224,7 @@ int load_crashdump_segments(struct kexec
> > if (get_crash_memory_ranges(&mem_range, &nr_ranges) == 0) {
> >
> > info->kern_paddr_start = kernel_code_start;
> > - info->kern_vaddr_start = LOAD_OFFSET;
> > + info->kern_vaddr_offset = LOAD_OFFSET;
>
> Hi Magnus,
>
> I am unable to understand the introduction if info->kern_vaddr_offset
> and then special handling of it while creating the 64 bit headers. Can
> you please explain a bit more why it is required. Why can't we go the
> regular way of getting the kernel virtual and physical address and continue
> creating a separate header for it for IA64?
The special handling of kern_vaddr_offset is there because we need to
scan through the memory segments to get the physical address that we
then add to kern_vaddr_offset. This is different compared to
kern_vaddr_start which only contains a fixed value.
I'm sure there are several ways to implement this - like x86_64 does -
but at the moment i'd like to get a release out that works on ia64
without breaking x86_64. If someone can come up with a better fix that
just correctly calculates kern_vaddr_start in crashdump-ia64.c then
that would be even better than my fix.
Thanks!
/ magnus
_______________________________________________
fastboot mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/fastboot
