On Tue, Feb 27, 2007 at 11:25:07AM +0530, Sachin P. Sant wrote: > On x86_64 machines running kernels having relocatale kernel patches > compilation of kexec tools fails with following error. > > kexec/arch/i386/kexec-multiboot-x86.c:347: warning: implicit > declaration of function ‘_AC’ > kexec/arch/i386/kexec-multiboot-x86.c:347: error: ‘UL’ undeclared > (first use in this function) > kexec/arch/i386/kexec-multiboot-x86.c:347: error: (Each undeclared > identifier is reported only once > kexec/arch/i386/kexec-multiboot-x86.c:347: error: for each > function it appears in.) > > The error is bacause of the use of PAGE_SIZE macro in the above > file. On x86_64 arch PAGE_SIZE is defined as > > #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > > and hence fails to find definition for _AC(). > > The correct way to fix this is to use getpagesize() function > instead of PAGE_SIZE macro. > > Attached is a patch for the same. Please review. >
Looks good to me. Thanks Vivek _______________________________________________ fastboot mailing list [email protected] https://lists.osdl.org/mailman/listinfo/fastboot
