On Wed, Mar 07, 2007 at 01:52:18PM +0530, Vivek Goyal wrote:
> 
> o Load purgatory below 2G while loading bzImage. x86_64 purgatory got
>   relocation types R_X86_64_32S hence got to be below 2G.

Thanks. I've applied this. However the grammar in the comment seems a
little weird to me.  Is the patch below an improvement?

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

diff --git a/kexec/arch/i386/kexec-bzImage.c b/kexec/arch/i386/kexec-bzImage.c
index 19fef11..b960193 100644
--- a/kexec/arch/i386/kexec-bzImage.c
+++ b/kexec/arch/i386/kexec-bzImage.c
@@ -182,9 +182,9 @@ int do_bzImage_load(struct kexec_info *info,
         * the the argument/parameter segment or the kernel will stomp
         * it's gdt.
         *
-        * x86_64 purgatory code has got relocations type R_X86_64_32S
-        * that means purgatory got to be loaded within first 2G otherwise
-        * overflow takes place while applying relocations.
+        * x86_64 purgatory code has relocation type R_X86_64_32S.
+        * This means that purgatory needs to be loaded within the first 2Gb,
+        * otherwise overflow will occur when applying the relocation.
         */
        if (!real_mode_entry && relocatable_kernel)
                elf_rel_build_load(info, &info->rhdr, purgatory, purgatory_size,
_______________________________________________
fastboot mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/fastboot

Reply via email to