Changes have been pushed for the repository "fawkes.git". (Fawkes Robotics Software Framework)
Clone: g...@git.fawkesrobotics.org:fawkes.git Gitweb: http://git.fawkesrobotics.org/fawkes.git Trac: http://trac.fawkesrobotics.org The branch, vmatare/protobuf_comm has been updated discards db80d321ad8ee92d3bde10ae19276c354a9c4bc1 (commit) to 5e7083451579f6ead2dbc9e0369ef08c4a012df2 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (db80d321ad8ee92d3bde10ae19276c354a9c4bc1) \ N -- N -- N (5e7083451579f6ead2dbc9e0369ef08c4a012df2) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. http://git.fawkesrobotics.org/fawkes.git/vmatare/protobuf_comm Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - *Log* --------------------------------------------------------------- commit 5e7083451579f6ead2dbc9e0369ef08c4a012df2 Author: Victor Mataré <mat...@lih.rwth-aachen.de> AuthorDate: Wed Nov 8 12:24:27 2017 +0100 Commit: Victor Mataré <mat...@lih.rwth-aachen.de> CommitDate: Wed Nov 8 12:24:27 2017 +0100 protobuf_comm: use const reference args where possible Using mutable references prevents passing in rvalues/xvalues http://git.fawkesrobotics.org/fawkes.git/commit/5e70834 http://trac.fawkesrobotics.org/changeset/5e70834 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - *Summary* ----------------------------------------------------------- src/libs/protobuf_comm/message_register.cpp | 4 ++-- src/libs/protobuf_comm/message_register.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) - *Diffs* ------------------------------------------------------------- - *commit* 5e7083451579f6ead2dbc9e0369ef08c4a012df2 - - - - - - - - - - Author: Victor Mataré <mat...@lih.rwth-aachen.de> Date: Wed Nov 8 12:24:27 2017 +0100 Subject: protobuf_comm: use const reference args where possible src/libs/protobuf_comm/message_register.cpp | 8 ++++---- src/libs/protobuf_comm/message_register.h | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) _Diff for modified files_: diff --git a/src/libs/protobuf_comm/message_register.cpp b/src/libs/protobuf_comm/message_register.cpp index 5a550d0..5d10fa9 100644 --- a/src/libs/protobuf_comm/message_register.cpp +++ b/src/libs/protobuf_comm/message_register.cpp @@ -71,7 +71,7 @@ MessageRegister::MessageRegister() * within these files will automatically be registered and available for dynamic * message creation. */ -MessageRegister::MessageRegister(std::vector<std::string> &proto_path) +MessageRegister::MessageRegister(const std::vector<std::string> &proto_path) { pb_srctree_ = new google::protobuf::compiler::DiskSourceTree(); for (size_t i = 0; i < proto_path.size(); ++i) { @@ -122,7 +122,7 @@ MessageRegister::~MessageRegister() google::protobuf::Message * -MessageRegister::create_msg(std::string &msg_type) +MessageRegister::create_msg(const std::string &msg_type) { const google::protobuf::DescriptorPool *pool = google::protobuf::DescriptorPool::generated_pool(); @@ -254,7 +254,7 @@ MessageRegister::new_message_for(uint16_t component_id, uint16_t msg_type) * for the given message type. */ std::shared_ptr<google::protobuf::Message> -MessageRegister::new_message_for(std::string &full_name) +MessageRegister::new_message_for(const std::string &full_name) { std::lock_guard<std::mutex> lock(maps_mutex_); if (message_by_typename_.find(full_name) == message_by_typename_.end()) { @@ -283,7 +283,7 @@ MessageRegister::new_message_for(std::string &full_name) */ void MessageRegister::serialize(uint16_t component_id, uint16_t msg_type, - google::protobuf::Message &msg, + const google::protobuf::Message &msg, frame_header_t &frame_header, message_header_t &message_header, std::string &data) diff --git a/src/libs/protobuf_comm/message_register.h b/src/libs/protobuf_comm/message_register.h index 6ece49b..a0db9cd 100644 --- a/src/libs/protobuf_comm/message_register.h +++ b/src/libs/protobuf_comm/message_register.h @@ -70,7 +70,7 @@ class MessageRegister : boost::noncopyable { public: MessageRegister(); - MessageRegister(std::vector<std::string> &proto_path); + MessageRegister(const std::vector<std::string> &proto_path); ~MessageRegister(); void add_message_type(std::string msg_type); @@ -133,10 +133,10 @@ class MessageRegister : boost::noncopyable new_message_for(uint16_t component_id, uint16_t msg_type); std::shared_ptr<google::protobuf::Message> - new_message_for(std::string &full_name); + new_message_for(const std::string &full_name); void serialize(uint16_t component_id, uint16_t msg_type, - google::protobuf::Message &msg, + const google::protobuf::Message &msg, frame_header_t &frame_header, message_header_t &message_header, std::string &data); @@ -162,7 +162,7 @@ class MessageRegister : boost::noncopyable typedef std::map<std::string, google::protobuf::Message *> TypeNameMap; KeyType key_from_desc(const google::protobuf::Descriptor *desc); - google::protobuf::Message * create_msg(std::string &msg_type); + google::protobuf::Message * create_msg(const std::string &msg_type); std::mutex maps_mutex_; TypeMap message_by_comp_type_; -- Fawkes Robotics Framework http://www.fawkesrobotics.org
_______________________________________________ fawkes-commits mailing list fawkes-commits@lists.kbsg.rwth-aachen.de https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits
