Changes have been pushed for the repository "fawkes.git". (Fawkes Robotics Software Framework)
Clone: g...@git.fawkesrobotics.org:fawkes.git Gitweb: http://git.fawkesrobotics.org/fawkes.git Trac: http://trac.fawkesrobotics.org The branch, vmatare/navigator-stop-race-fix has been updated to 13ecd7cb7d2f732e9793657c64314eec03865fa5 (commit) from f2dff04eb66faf2c8e4717d9689a8e3c5828cfce (commit) http://git.fawkesrobotics.org/fawkes.git/vmatare/navigator-stop-race-fix Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - *Log* --------------------------------------------------------------- commit 13ecd7cb7d2f732e9793657c64314eec03865fa5 Author: Tim Niemueller <niemuel...@kbsg.rwth-aachen.de> AuthorDate: Fri Feb 16 17:00:53 2018 +0100 Commit: Tim Niemueller <niemuel...@kbsg.rwth-aachen.de> CommitDate: Fri Feb 16 17:00:53 2018 +0100 navgraph: fix use after free issue Messages are consumed by the call to msgq_enqueue(). Properly ref and unref to mitigate use after free. http://git.fawkesrobotics.org/fawkes.git/commit/13ecd7c http://trac.fawkesrobotics.org/changeset/13ecd7c - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - *Summary* ----------------------------------------------------------- src/plugins/navgraph/navgraph_thread.cpp | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) - *Diffs* ------------------------------------------------------------- - *commit* 13ecd7cb7d2f732e9793657c64314eec03865fa5 - - - - - - - - - - Author: Tim Niemueller <niemuel...@kbsg.rwth-aachen.de> Date: Fri Feb 16 17:00:53 2018 +0100 Subject: navgraph: fix use after free issue src/plugins/navgraph/navgraph_thread.cpp | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) _Diff for modified files_: diff --git a/src/plugins/navgraph/navgraph_thread.cpp b/src/plugins/navgraph/navgraph_thread.cpp index 6c05311..f60f84e 100644 --- a/src/plugins/navgraph/navgraph_thread.cpp +++ b/src/plugins/navgraph/navgraph_thread.cpp @@ -833,8 +833,11 @@ NavGraphThread::send_next_goal() tpose.getOrigin().x(), tpose.getOrigin().y(), tf::get_yaw(tpose.getRotation()), next_target.name().c_str()); + + gotomsg->ref(); nav_if_->msgq_enqueue(gotomsg); cmd_msgid_ = gotomsg->id(); + gotomsg->unref(); cmd_sent_at_->stamp(); error_at_->stamp(); -- Fawkes Robotics Framework http://www.fawkesrobotics.org _______________________________________________ fawkes-commits mailing list fawkes-commits@lists.kbsg.rwth-aachen.de https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits
