Changes have been pushed for the repository "fawkesrobotics/fawkes".

Clone:  https://github.com/fawkesrobotics/fawkes.git
Gitweb: https://github.com/fawkesrobotics/fawkes

The branch, thofmann/buildkite-fedora30 has been updated
  discards  cb1fada9ee48b5bae4ed5f0f55cee9c705d5d354 (commit)
  discards  2a24dcebdb0af354dbbe0cbddf9e670cbeaa3a06 (commit)
  discards  1d17fecbeea7df0d0246dae72ef9f5e4ec47305e (commit)
  discards  e7ae6f06c4bb44d33c5f4d5ac22169f386cf213f (commit)
  discards  3caa51eb1a7b720ec6a35e9448e94ae33c283dd1 (commit)
  discards  012f0708c53de81cd8c9ed2d3b7434d9773c872a (commit)
  discards  b8dad0548a340b915431a545e11c4d8ac05f42cd (commit)
  discards  e9b22bc51a52b3b1fa2eeed06f2c413b1191890d (commit)
  discards  92069ae56377e067838d7efbfac3f95aa86a90b4 (commit)
  discards  f8052736d2fc5e6b3dc5e9a8d3dcfa8370038d09 (commit)
        to  5fa4bfa4d37b3ab71f022fbbc6808df381176915 (commit)
       via  633b4dd2870a31528d100a497588aa0ca87e69e4 (commit)
       via  99c02d0558cf09123dbf5522ec63725c9391befc (commit)
       via  cbc6fc809917273dfdc7595fb3e730090f92c884 (commit)
       via  4abef746ad714080833cfdcab69715803d2fc716 (commit)
       via  aaceac46b62e30b155f9fb761532583cd2b1b3d2 (commit)
       via  11c448163912be3edaba3f9c93e8677bcfdd2af2 (commit)
       via  6f71a9521d90b4b4adff8fc18ba007c3aac61473 (commit)
       via  522181e785d764deb6bdc733b75bda10123daf24 (commit)
       via  22174013c8ffa57c53e32f519b8794348b4eaf89 (commit)
       via  ea2d69189435c5b4dab293007b7affbd9d265eb4 (commit)
       via  c29ad858ad2e82d66ffaf72237c1f3c45d3a1f4e (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (cb1fada9ee48b5bae4ed5f0f55cee9c705d5d354)
            \
             N -- N -- N (5fa4bfa4d37b3ab71f022fbbc6808df381176915)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

https://github.com/fawkesrobotics/fawkes/tree/thofmann/buildkite-fedora30

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- *Log* ---------------------------------------------------------------
commit 22174013c8ffa57c53e32f519b8794348b4eaf89
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:06:03 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    buildkite: switch to fedora30-melodic as builder image
    
    Upgrade from Fedora 29 to Fedora 30 and also upgrade the ROS
    distribution from kinetic to melodic along the way.

https://github.com/fawkesrobotics/fawkes/commit/22174013c

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 522181e785d764deb6bdc733b75bda10123daf24
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:08:10 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    core: reformat code with updated clang-format
    
    Automatically performed using format target and clang-format on Fedora 30.
    
    Automatically committed using:
    for f in $(git ls-files --modified | awk -F/ '{ print $1 }' | sort -u); do
      cat <<EOM | git commit -F- $f
        THIS MESSAGE
      EOM
    done

https://github.com/fawkesrobotics/fawkes/commit/522181e78

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 6f71a9521d90b4b4adff8fc18ba007c3aac61473
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:08:26 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    asp: reformat code with updated clang-format
    
    Automatically performed using format target and clang-format on Fedora 30.
    
    Automatically committed using:
    for f in $(git ls-files --modified | awk -F/ '{ print $1 }' | sort -u); do
      cat <<EOM | git commit -F- $f
        THIS MESSAGE
      EOM
    done

https://github.com/fawkesrobotics/fawkes/commit/6f71a9521

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 11c448163912be3edaba3f9c93e8677bcfdd2af2
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:24:01 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    blackboard: fix doxygen documentation
    
    On Fedora 30, doxygen does not accept the default arguments being
    mentioned in the documentation, thus remove them.

https://github.com/fawkesrobotics/fawkes/commit/11c448163

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit aaceac46b62e30b155f9fb761532583cd2b1b3d2
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:25:26 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    pcl-db: fix duplicate parameter documentation

https://github.com/fawkesrobotics/fawkes/commit/aaceac46b

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 4abef746ad714080833cfdcab69715803d2fc716
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:30:51 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    syncpoint: fix doxygen documentation
    
    We need to document each member of the class, documenting just the group
    produces a warning on Fedora 30.

https://github.com/fawkesrobotics/fawkes/commit/4abef746a

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit cbc6fc809917273dfdc7595fb3e730090f92c884
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:34:40 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    core: fix duplicate documentation of the ThreadLoopListener

https://github.com/fawkesrobotics/fawkes/commit/cbc6fc809

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 99c02d0558cf09123dbf5522ec63725c9391befc
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:42:59 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    libwebview: remove duplicate documentation

https://github.com/fawkesrobotics/fawkes/commit/99c02d055

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 633b4dd2870a31528d100a497588aa0ca87e69e4
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:43:21 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    fvclassifiers: remove duplicate documentation

https://github.com/fawkesrobotics/fawkes/commit/633b4dd28

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
commit 5fa4bfa4d37b3ab71f022fbbc6808df381176915
Author:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
AuthorDate: Tue Sep 24 10:45:21 2019 +0200
Commit:     Till Hofmann <hofm...@kbsg.rwth-aachen.de>
CommitDate: Wed Sep 25 09:56:14 2019 +0200

    fvmodels: remove duplicate documentation

https://github.com/fawkesrobotics/fawkes/commit/5fa4bfa4d

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -


- *Summary* -----------------------------------------------------------
 src/libs/interfaces/generator/cpp_generator.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


- *Diffs* -------------------------------------------------------------

- *commit* 22174013c8ffa57c53e32f519b8794348b4eaf89 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:06:03 2019 +0200
Subject: buildkite: switch to fedora30-melodic as builder image

 .buildkite/pipeline.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_Diff for modified files_:
diff --git a/.buildkite/pipeline.yml b/.buildkite/pipeline.yml
index 899de22e5..035629189 100644
--- a/.buildkite/pipeline.yml
+++ b/.buildkite/pipeline.yml
@@ -6,7 +6,7 @@ merged-pr-plugin: &merged-pr-plugin
     mode: checkout
 
 docker-plugin-base: &docker-plugin-base
-  image: fawkesrobotics/fawkes-builder:fedora29-kinetic
+  image: fawkesrobotics/fawkes-builder:fedora30-melodic
   always-pull: true
   debug: true
   environment: ["BUILDKITE", "BUILDKITE_LABEL"]

- *commit* 522181e785d764deb6bdc733b75bda10123daf24 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:08:10 2019 +0200
Subject: core: reformat code with updated clang-format

 src/libs/core/assert_exception.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_Diff for modified files_:
diff --git a/src/libs/core/assert_exception.h b/src/libs/core/assert_exception.h
index 08020740a..68809e5fa 100644
--- a/src/libs/core/assert_exception.h
+++ b/src/libs/core/assert_exception.h
@@ -39,6 +39,6 @@
 #define assert(expr)                 \
        ((expr) ? __ASSERT_VOID_CAST(0)    \
                : throw fawkes::Exception( \
-                   "Assertion '%s' failed in %s:%u", __STRING(expr), __FILE__, 
__LINE__))
+                 "Assertion '%s' failed in %s:%u", __STRING(expr), __FILE__, 
__LINE__))
 
 #endif

- *commit* 6f71a9521d90b4b4adff8fc18ba007c3aac61473 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:08:26 2019 +0200
Subject: asp: reformat code with updated clang-format

 src/plugins/asp/aspect/clingo_access.cpp | 64 +++++++++++++++-----------------
 1 file changed, 30 insertions(+), 34 deletions(-)

_Diff for modified files_:
diff --git a/src/plugins/asp/aspect/clingo_access.cpp 
b/src/plugins/asp/aspect/clingo_access.cpp
index 66573101f..5823bc039 100644
--- a/src/plugins/asp/aspect/clingo_access.cpp
+++ b/src/plugins/asp/aspect/clingo_access.cpp
@@ -272,28 +272,23 @@ ClingoAccess::alloc_control()
                argumentsChar.push_back(argumentsString.back().c_str());
        }
 
-       control_ = new Clingo::Control(argumentsChar,
-                                      [this](const Clingo::WarningCode code, 
char const *msg) {
-                                              fawkes::Logger::LogLevel level = 
fawkes::Logger::LL_NONE;
-                                              switch (code) {
-                                              case 
Clingo::WarningCode::AtomUndefined:
-                                              case 
Clingo::WarningCode::OperationUndefined:
-                                              case 
Clingo::WarningCode::RuntimeError:
-                                                      level = 
fawkes::Logger::LL_ERROR;
-                                                      break;
-                                              case Clingo::WarningCode::Other:
-                                              case 
Clingo::WarningCode::VariableUnbounded:
-                                                      level = 
fawkes::Logger::LL_WARN;
-                                                      break;
-                                              case 
Clingo::WarningCode::FileIncluded:
-                                              case 
Clingo::WarningCode::GlobalVariable:
-                                                      level = 
fawkes::Logger::LL_INFO;
-                                                      break;
-                                              }
-                                              logger_->log(level, 
log_comp_.c_str(), msg);
-                                              return;
-                                      },
-                                      100);
+       control_ = new Clingo::Control(
+         argumentsChar,
+         [this](const Clingo::WarningCode code, char const *msg) {
+                 fawkes::Logger::LogLevel level = fawkes::Logger::LL_NONE;
+                 switch (code) {
+                 case Clingo::WarningCode::AtomUndefined:
+                 case Clingo::WarningCode::OperationUndefined:
+                 case Clingo::WarningCode::RuntimeError: level = 
fawkes::Logger::LL_ERROR; break;
+                 case Clingo::WarningCode::Other:
+                 case Clingo::WarningCode::VariableUnbounded: level = 
fawkes::Logger::LL_WARN; break;
+                 case Clingo::WarningCode::FileIncluded:
+                 case Clingo::WarningCode::GlobalVariable: level = 
fawkes::Logger::LL_INFO; break;
+                 }
+                 logger_->log(level, log_comp_.c_str(), msg);
+                 return;
+         },
+         100);
        return;
 }
 
@@ -617,18 +612,19 @@ ClingoAccess::assign_external(const Clingo::Symbol &atom, 
const Clingo::TruthVal
        }
 
        if (debug_level_ >= ASP_DBG_EXTERNALS) {
-               logger_->log_info(log_comp_.c_str(),
-                                 "Assigning %s to %s.",
-                                 [value](void) {
-                                         const char *ret = "Unknown Value";
-                                         switch (value) {
-                                         case Clingo::TruthValue::Free: ret = 
"Free"; break;
-                                         case Clingo::TruthValue::True: ret = 
"True"; break;
-                                         case Clingo::TruthValue::False: ret = 
"False"; break;
-                                         }
-                                         return ret;
-                                 }(),
-                                 atom.to_string().c_str());
+               logger_->log_info(
+                 log_comp_.c_str(),
+                 "Assigning %s to %s.",
+                 [value](void) {
+                         const char *ret = "Unknown Value";
+                         switch (value) {
+                         case Clingo::TruthValue::Free: ret = "Free"; break;
+                         case Clingo::TruthValue::True: ret = "True"; break;
+                         case Clingo::TruthValue::False: ret = "False"; break;
+                         }
+                         return ret;
+                 }(),
+                 atom.to_string().c_str());
        }
        control_->assign_external(atom, value);
        return true;

- *commit* 11c448163912be3edaba3f9c93e8677bcfdd2af2 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:24:01 2019 +0200
Subject: blackboard: fix doxygen documentation

 src/libs/blackboard/blackboard.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

_Diff for modified files_:
diff --git a/src/libs/blackboard/blackboard.cpp 
b/src/libs/blackboard/blackboard.cpp
index e97589778..498c8673e 100644
--- a/src/libs/blackboard/blackboard.cpp
+++ b/src/libs/blackboard/blackboard.cpp
@@ -128,7 +128,7 @@ namespace fawkes {
  * @return true if the aliveness could be restored and the BlackBoard is
  * operational again, false otherwise.
  *
- * @fn std::list<Interface *>  BlackBoard::open_multiple_for_reading(const 
char *type_pattern, const char *id_pattern = "*", const char *owner = NULL)
+ * @fn std::list<Interface *>  BlackBoard::open_multiple_for_reading(const 
char *type_pattern, const char *id_pattern, const char *owner)
  * Open multiple interfaces for reading.
  * This will create interface instances for currently registered interfaces of
  * the given type that match the given ID pattern. The result can be casted to

- *commit* aaceac46b62e30b155f9fb761532583cd2b1b3d2 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:25:26 2019 +0200
Subject: pcl-db: fix duplicate parameter documentation

 src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h | 1 -
 1 file changed, 1 deletion(-)

_Diff for modified files_:
diff --git a/src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h 
b/src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h
index 57b207ee6..13ec391e8 100644
--- a/src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h
+++ b/src/plugins/perception/pcl-db/pcl_db_retrieve_pipeline.h
@@ -58,7 +58,6 @@ public:
    * @param mongodb_client MongoDB client
    * @param config configuration
    * @param logger Logger
-   * @param output output point cloud
    * @param transformer TF transformer for point cloud transformations between
    * coordinate reference frames
    * @param original input point cloud

- *commit* 4abef746ad714080833cfdcab69715803d2fc716 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:30:51 2019 +0200
Subject: syncpoint: fix doxygen documentation

 src/libs/syncpoint/tests/test_syncpoint.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/syncpoint/tests/test_syncpoint.cpp 
b/src/libs/syncpoint/tests/test_syncpoint.cpp
index 499883a4e..353cd0957 100644
--- a/src/libs/syncpoint/tests/test_syncpoint.cpp
+++ b/src/libs/syncpoint/tests/test_syncpoint.cpp
@@ -75,14 +75,12 @@ protected:
                delete logger_;
        }
 
-       /**@{*/
-       /**
-     * Syncpoints for testing purposes
-     */
+       /** A syncpoint for testing */
        RefPtr<SyncPoint> sp1;
+       /** A syncpoint for testing */
        RefPtr<SyncPoint> sp2;
+       /** A syncpoint for testing */
        RefPtr<SyncPoint> sp3;
-       /**@}*/
 
        /** Logger for testing */
        MultiLogger *logger_;

- *commit* cbc6fc809917273dfdc7595fb3e730090f92c884 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:34:40 2019 +0200
Subject: core: fix duplicate documentation of the ThreadLoopListener

 src/libs/core/threading/thread_loop_listener.cpp | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/core/threading/thread_loop_listener.cpp 
b/src/libs/core/threading/thread_loop_listener.cpp
index 07fda7318..7b1cc5a6e 100644
--- a/src/libs/core/threading/thread_loop_listener.cpp
+++ b/src/libs/core/threading/thread_loop_listener.cpp
@@ -31,14 +31,6 @@ namespace fawkes {
  * tasks, which are executed before and after every loop.
  *
  * @author Till Hofmann
- *
- * @fn void ThreadLoopListener::pre_loop(Thread thread*)
- * This is called by the thread every time before loop() is called.
- * @param thread thread whose loop() is will be called.
- *
- * @fn void ThreadLoopListener::post_loop(Thread thread*)
- * This is called by the thread every time after loop() returned.
- * @param thread thread whose loop() just returned.
  */
 
 /** Virtual empty destructor. */
@@ -47,7 +39,7 @@ ThreadLoopListener::~ThreadLoopListener()
 }
 
 /** Empty stub for the pre loop function of the loop listener.
- * This function is called right before the loop of the thread with the aspect.
+ * This function is called by the thread every time before loop() is called.
  * Provide a stub such that not every derived class must implement the 
function.
  * @param thread thread this loop listener belongs to
  */
@@ -57,7 +49,7 @@ ThreadLoopListener::pre_loop(Thread *thread)
 }
 
 /** Empty stub for the post loop function of the loop listener.
- * This function is called right after the loop of the thread with the aspect.
+ * This function is called by the thread every time after loop() returned.
  * Provide a stub such that not every derived class must implement the 
function.
  * @param thread thread this loop listener belongs to
  */

- *commit* 99c02d0558cf09123dbf5522ec63725c9391befc - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:42:59 2019 +0200
Subject: libwebview: remove duplicate documentation

 src/libs/webview/request.h | 5 -----
 1 file changed, 5 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/webview/request.h b/src/libs/webview/request.h
index 46b5feaad..1cfa1bc76 100644
--- a/src/libs/webview/request.h
+++ b/src/libs/webview/request.h
@@ -268,11 +268,6 @@ public:
                cookies_[key] = value;
        }
 
-       /** Set a POST value.
-   * @param key key of the cookie
-   * @param data incoming data
-   * @param size size in bytes of @p data
-   */
        void set_post_value(const char *key, const char *data, size_t size);
 
        /** Set a GET value.

- *commit* 633b4dd2870a31528d100a497588aa0ca87e69e4 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:43:21 2019 +0200
Subject: fvclassifiers: remove duplicate documentation

 src/libs/fvclassifiers/border_shrinker.h | 8 --------
 1 file changed, 8 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/fvclassifiers/border_shrinker.h 
b/src/libs/fvclassifiers/border_shrinker.h
index dca1741ca..4b3da49b7 100644
--- a/src/libs/fvclassifiers/border_shrinker.h
+++ b/src/libs/fvclassifiers/border_shrinker.h
@@ -33,14 +33,6 @@ class ROI;
 class BorderShrinker : public Shrinker
 {
 public:
-       /** CloseShrinker shrinks ROIs
-   * It will make sure that any ROI that passes it will NOT be in the border 
regions
-   * denoted by the pixels
-   * @param border_left left pixel margin
-   * @param border_right right pixel margin
-   * @param border_top top pixel margin
-   * @param border_bottom botto pixel margin
-   */
        BorderShrinker(unsigned int border_left   = 0,
                       unsigned int border_right  = 0,
                       unsigned int border_top    = 0,

- *commit* 5fa4bfa4d37b3ab71f022fbbc6808df381176915 - - - - - - - - - -
Author:  Till Hofmann <hofm...@kbsg.rwth-aachen.de>
Date:    Tue Sep 24 10:45:21 2019 +0200
Subject: fvmodels: remove duplicate documentation

 src/libs/fvmodels/shape/ht_lines.cpp | 23 ++++++++++++++++-------
 src/libs/fvmodels/shape/ht_lines.h   | 16 ----------------
 2 files changed, 16 insertions(+), 23 deletions(-)

_Diff for modified files_:
diff --git a/src/libs/fvmodels/shape/ht_lines.cpp 
b/src/libs/fvmodels/shape/ht_lines.cpp
index 07dc4c11e..44b2003b6 100644
--- a/src/libs/fvmodels/shape/ht_lines.cpp
+++ b/src/libs/fvmodels/shape/ht_lines.cpp
@@ -41,13 +41,22 @@ namespace firevision {
  */
 
 /** Constructor.
- * @param nr_candidates number of candidates
- * @param angle_from slope of lines from
- * @param angle_range angle range
- * @param r_scale r scale
- * @param min_votes_ratio min votes ratio
- * @param min_votes minimum number of votes for a candidate to consider
- */
+  * Creates a new HtLinesModel instance
+  * @param nr_candidates the nr of candidates that is considered per pixel 
(the hole angle
+  *                      range is devided in this many parts/lines
+  * @param angle_from The angle to start the candidates from, given in rad, 0 
is straight up
+  * @param angle_range the angle range the candidates are taken from starting 
at angle_from,
+  *                    given in rad, can be used for example to only search 
for horizontal lines
+  * @param r_scale This can be done to reduce the size of the hough space and 
to map more lines
+  *                to one line
+  * @param min_votes_ratio The minimum ratio 
num_votes_per_line/total_num_votes that we have to
+  *                        have before a point in the hough space is 
considered to be a line,
+  *                        this may actually be higher if you use min_votes 
and set it to a higher
+  *                        number (set min_votes to 0 to only use 
min_votes_ration)
+  * @param min_votes the minimum number of votes a point in the hough space 
has to have before it
+  *                  is considered to be a line. The number may actually be 
higher if min_votes_ratio
+  *                  is set too high (set min_votes_ration to 0 to use only 
min_votes)
+  */
 HtLinesModel::HtLinesModel(unsigned int nr_candidates,
                            float        angle_from,
                            float        angle_range,
diff --git a/src/libs/fvmodels/shape/ht_lines.h 
b/src/libs/fvmodels/shape/ht_lines.h
index 3cdbaea37..9c9f0512d 100644
--- a/src/libs/fvmodels/shape/ht_lines.h
+++ b/src/libs/fvmodels/shape/ht_lines.h
@@ -44,22 +44,6 @@ private:
        RhtAccumulator         accumulator;
 
 public:
-       /** Creates a new HtLinesModel instance
-   * @param nr_candidates the nr of candidates that is considered per pixel 
(the hole angle
-   *                      range is devided in this many parts/lines
-   * @param angle_from The angle to start the candidates from, given in rad, 0 
is straight up
-   * @param angle_range the angle range the candidates are taken from starting 
at angle_from,
-   *                    given in rad, can be used for example to only search 
for horizontal lines
-   * @param r_scale This can be done to reduce the size of the hough space and 
to map more lines
-   *                to one line
-   * @param min_votes_ratio The minimum ratio 
num_votes_per_line/total_num_votes that we have to
-   *                        have before a point in the hough space is 
considered to be a line,
-   *                        this may actually be higher if you use min_votes 
and set it to a higher
-   *                        number (set min_votes to 0 to only use 
min_votes_ration)
-   * @param min_votes the minimum number of votes a point in the hough space 
has to have before it
-   *                  is considered to be a line. The number may actually be 
higher if min_votes_ratio
-   *                  is set too high (set min_votes_ration to 0 to use only 
min_votes)
-   */
        HtLinesModel(unsigned int nr_candidates   = 40,
                     float        angle_from      = 0,
                     float        angle_range     = 2 * M_PI,



_______________________________________________
fawkes-commits mailing list
fawkes-commits@lists.kbsg.rwth-aachen.de
https://lists.kbsg.rwth-aachen.de/listinfo/fawkes-commits

Reply via email to