> From: Hannes Reinecke [mailto:[email protected]] > Sent: Monday, January 28, 2013 12:12 AM > > This patch adds an option '-u' / '--link-up' to leave the network interface > running if a VLAN has been detected. > > Signed-off-by: Hannes Reinecke <[email protected]> > --- > doc/fipvlan.8 | 6 +++++- > doc/fipvlan.txt | 2 +- > fipvlan.c | 36 +++++++++++++++++++++++++----------- > 3 files changed, 31 insertions(+), 13 deletions(-) > > diff --git a/doc/fipvlan.8 b/doc/fipvlan.8 index ba9daf7..20525cf 100644 > --- a/doc/fipvlan.8 > +++ b/doc/fipvlan.8 > @@ -20,7 +20,7 @@ > fipvlan \- Fibre Channel over Ethernet VLAN Discovery .SH "SYNOPSIS" > .sp > -\fBfipvlan\fR [\-c|\-\-create] [\-s|\-\-start] \fIinterfaces\fR > +\fBfipvlan\fR [\-c|\-\-create] [\-s|\-\-start] [\-d|\-\-debug] > +\fIinterfaces\fR > .sp > \fBfipvlan\fR \-a|\-\-auto [\-c|\-\-create] [\-d|\-\-debug] [\-s|\-\-start] > [\- > l|\-\-link-retry <num>] @@ -82,6 +82,10 @@ Append the specified string > \fI<suffix string>\fR to VLAN interface names. > .RS 4 > Retry check for link up up to \fI<number of retries>\fR times. The link > state > is retried every 500 ms. The default is 20. > +.PP > +\fB\-u\fR, \fB\-\-link-up\fR > +.RS 4 > +Leave link up if VLAN has been detected.
I think this descriptive text is missing from fipvlan.txt. The easiest way to make sure nothing is missing is to convert the .txt file into the man page. I know this is obscure to contributors, but can you please run 'make' in the fcoe-utils.git/doc/ directory it will generate the foo.8 files from the foo.txt files. That way they'll stay in sync. > .RE > .PP > \fB\-h\fR, \fB\-\-help\fR > diff --git a/doc/fipvlan.txt b/doc/fipvlan.txt index fc63536..d1b5c87 100644 > --- a/doc/fipvlan.txt > +++ b/doc/fipvlan.txt > @@ -19,7 +19,7 @@ fipvlan - Fibre Channel over Ethernet VLAN Discovery > > SYNOPSIS > -------- > -*fipvlan* [-c|--create] [-s|--start] _interfaces_ > +*fipvlan* [-c|--create] [-s|--start] [-d|--debug] [-l|--link-retry] > +_interfaces_ Also, above it's '--link-up', but here it's '--link-retry'. > > *fipvlan* -a|--auto [-c|--create] [-d|--debug] > [-s|--start] [-l|--link-retry _count_] diff --git a/fipvlan.c b/fipvlan.c > index > 83df532..e47b30d 100644 _______________________________________________ fcoe-devel mailing list [email protected] http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
