The client expects the string-ized error code to be an
'enum fcoe_status'. This patch ensures that callers pass
this type as the 'status' argument and thus provides better
type checking.

Signed-off-by: Robert Love <[email protected]>
Tested-by: Marcus Dennis <[email protected]>
---
 fcoemon.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/fcoemon.c b/fcoemon.c
index 13af6a9..12981f9 100644
--- a/fcoemon.c
+++ b/fcoemon.c
@@ -2502,7 +2502,10 @@ static void fcm_dcbd_event(char *msg, size_t len)
        }
 }
 
-static void fcm_cli_reply(struct sock_info *r, int status)
+/*
+ * The status is interpreted by the client as an 'enum fcoe_status'.
+ */
+static void fcm_cli_reply(struct sock_info *r, enum fcoe_status status)
 {
        char rbuf[MAX_MSGBUF];
        snprintf(rbuf, MSG_RBUF, "%d", status);

_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel

Reply via email to