On Mon, Jun 10, 2013 at 04:28:19PM -0700, Robert Love wrote:
> ctlr_dev was initialized to NULL, and never re-assigned. This
> caused the log statement to always report failure. This patch
> removes the unused variable and fixes the log statement to always
> report 'success', as that is what should be logged if the code
> reaches this point.
>
> Signed-off-by: Robert Love <[email protected]>
> Tested-by: Jack Morgan<[email protected]>
> ---
> drivers/scsi/fcoe/fcoe_transport.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fcoe/fcoe_transport.c
> b/drivers/scsi/fcoe/fcoe_transport.c
> index f3a5a53..58c867c 100644
> --- a/drivers/scsi/fcoe/fcoe_transport.c
> +++ b/drivers/scsi/fcoe/fcoe_transport.c
> @@ -721,7 +721,6 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
> {
> struct net_device *netdev = NULL;
> struct fcoe_transport *ft = NULL;
> - struct fcoe_ctlr_device *ctlr_dev = NULL;
> int rc = 0;
> int err;
>
> @@ -768,9 +767,8 @@ ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
> goto out_putdev;
> }
>
> - LIBFCOE_TRANSPORT_DBG("transport %s %s to create fcoe on %s.\n",
> - ft->name, (ctlr_dev) ? "succeeded" : "failed",
> - netdev->name);
> + LIBFCOE_TRANSPORT_DBG("transport %s succeeded to create fcoe on %s.\n",
> + ft->name, netdev->name);
>
> out_putdev:
> dev_put(netdev);
>
> _______________________________________________
> fcoe-devel mailing list
> [email protected]
> http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
>
Acked-by: Neil Horman <[email protected]>
_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
