> Sent: Thursday, August 15, 2013 2:16 AM > To: [email protected] > Subject: Re: [Open-FCoE] [PATCH v3 1/4] fcnsq: Fix build warnings > > Robert Love <robert.w.love@...> writes: > > > - print_result("Port Name", "%16.16llx\n", wwpn); > > + print_result("Port Name", "%16.16" PRIx64 "\n", (u_int64_t)wwpn); > > Is it an option to change the declaration type of wwpn into uint64_t ? That > would allow to drop the cast in the above statement. Please note that > uint64_t has been defined in the C99 standard but u_int64_t not. > > > - sscanf(optarg, "%llx", &wwnn); > > + sscanf(optarg, "%" PRIx64, (u_int64_t *)&wwnn); > > I think it is recommended to use SCNx64 instead of PRIx64 in sscanf() calls. > > Hope this helps, >
It does. I'll make the change. Thanks, //Rob _______________________________________________ fcoe-devel mailing list [email protected] http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
