On Tue, 10 Jun 2014, Eddie Wai wrote:
On Fri, 2014-06-06 at 13:05 -0500, [email protected] wrote:
From: Shirish Pargaonkar <[email protected]>
Do not log error for netevents that need no action such as
NETDEV_REGISTER 0x0005, NETDEV_CHANGEADDR, and NETDEV_CHANGENAME.
It results in logging error messages such as these
[ 35.315872] bnx2fc: Unknown netevent 5
[ 35.315935] bnx2fc: Unknown netevent 8
[ 35.353866] bnx2fc: Unknown netevent 10
and generating bug reports.
Remove logging this message as an ERROR instead of turning them into
either DEBUG or INFO level messages.
Signed-by: Shirish Pargaonkar <[email protected]>
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 1d41f4b..c7388a8 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
@@ -856,7 +856,6 @@ static void bnx2fc_indicate_netevent(void *context,
unsigned long event,
return;
default:
- printk(KERN_ERR PFX "Unknown netevent %ld", event);
return;
}
Thanks for fixing this, Shirish. It makes sense to suppress the
unwanted netevent messages.
The patch looks good to me, but we should really get the current bnx2fc
maintainer from Qlogic to ACK this.
Acked-by: Eddie Wai <[email protected]>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks fine to me as well.
Acked-by: Chad Dupuis <[email protected]>
_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
