Hi Vasu,
Yes, skb->priority is set in both cases, but what I wanted to know was
that in hw accelerated case, why the vlan_tci isn't updated with the priority
as shown in the patch below, before sending it off to the NIC driver.
@@ -1669,6 +1669,8 @@ static int fcoe_xmit(struct fc_lport *lport, struct
fc_frame *fp)
fcoe->realdev->features & NETIF_F_HW_VLAN_CTAG_TX) {
/* must set skb->dev before calling vlan_put_tag */
skb->dev = fcoe->realdev;
+ skb->vlan_tci |= (skb->priority << VLAN_PRIO_SHIFT) &
+ VLAN_PRIO_MASK;
skb = __vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q),
vlan_dev_vlan_id(fcoe->netdev));
if (!skb)
-----Original Message-----
From: Dev, Vasu [mailto:[email protected]]
Sent: 06 September 2014 03:41
To: Karthik Jayanth Ponnuthurai; [email protected]
Subject: RE: [Open-FCoE] PCP field missing from vlan TCI
> -----Original Message-----
> From: [email protected] [mailto:fcoe-devel-
> [email protected]] On Behalf Of Karthik Jayanth Ponnuthurai
> Sent: Friday, September 05, 2014 7:14 AM
> To: [email protected]
> Subject: [Open-FCoE] PCP field missing from vlan TCI
>
> Hi Everyone,
>
> I noticed that in case of hw accelerated vlan tagging, the
> skb-
> >priority is not inserted into the PCP field of the skb->vlan_tci in
> >fcoe_xmit().
> The LLD driver has to take into account skb->priority separately. Can
> someone please explain the reasoning behind this.
>
skb->priority is set in either case of hw accelerated or not, in later case
the vlan
8021q module should be inserting the tag correctly with the set skb->priority
value.
//Vasu
_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
