> -----Original Message----- > From: fcoe-devel [mailto:[email protected]] On Behalf Of > Dev, Vasu > Sent: Monday, February 02, 2015 9:26 AM > To: Hannes Reinecke; [email protected] > Subject: Re: [Open-FCoE] [PATCH] fipvlan: fix broken fcoe start using fipvlan > > > -----Original Message----- > > From: fcoe-devel [mailto:[email protected]] On Behalf > > Of Hannes Reinecke > > Sent: Sunday, February 01, 2015 11:16 PM > > To: [email protected] > > Subject: Re: [Open-FCoE] [PATCH] fipvlan: fix broken fcoe start using > > fipvlan > > > > On 01/30/2015 11:30 PM, Vasu Dev wrote: > > > FCoE start is broken due to the link being never selected and that > > > is in turn due to bad vlan interface name compare against real > > > interface name passed for fip vlan discovery. > > > > > > This name compare is unnecessary and breaks fipvlan start option, so > > > this patch removes it to have fcoe start working again. > > > > > > I considered reducing compare to just the base real interface name > > > but that won't work in the case of existing vlan interface name is > > > already customized, so instead just don't check for the name. > > > > > > I verified this fixes the start using newly created vlan as well as > > > existing vlan, which could be down or already running. > > > > > > Signed-off-by: Vasu Dev <[email protected]> > > > --- > > > > > > fipvlan.c | 13 ------------- > > > 1 files changed, 0 insertions(+), 13 deletions(-) > > > > > > diff --git a/fipvlan.c b/fipvlan.c > > > index 4937173..9e494ee 100644 > > > --- a/fipvlan.c > > > +++ b/fipvlan.c > > > @@ -448,19 +448,6 @@ static void rtnl_recv_newlink(struct nlmsghdr > *nh) > > > memcpy(iff->mac_addr, RTA_DATA(ifla[IFLA_ADDRESS]), > > ETHER_ADDR_LEN); > > > strncpy(iff->ifname, RTA_DATA(ifla[IFLA_IFNAME]), IFNAMSIZ); > > > > > > - if (!config.automode) { > > > - int i, iff_selected = 0; > > > - > > > - for (i = 0; i < config.namec; i++) { > > > - if (!strcmp(iff->ifname, config.namev[i])) > > > - iff_selected = 1; > > > - } > > > - if (!iff_selected) { > > > - FIP_LOG_DBG("ignoring if %s\n", iff->ifname); > > > - free(iff); > > > - return; > > > - } > > > - } > > > if (ifla[IFLA_LINKINFO]) { > > > parse_linkinfo(linkinfo, ifla[IFLA_LINKINFO]); > > > /* Track VLAN devices separately */ > > > > > Hmm. This particular code it to match the interfaces from the > > rtnetlink message to those specified on the commandline. > > Otherwise fipvlan would go ahead and enable FCoE on every interface. > > > > Are you sure that this patch works even though only a single interface > > is specified on the commandline? > > > > Not removing checks breaks fipval -s and it should be working before these > checks in dec, 2013 but then not sure how it was fixed since those patches > changed code substantially. > > I'd count on not issuing VLAN request on any other interface in that case > instead of any pruning during rtnetlink responses for all the reasons I > explained in the patch description.
In fact this is the way it was before, so I'll do same again. I'm sending patch to fix this. Thanks, Vasu > _______________________________________________ > fcoe-devel mailing list > [email protected] > http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel _______________________________________________ fcoe-devel mailing list [email protected] http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
