NACK

This patch is causing problems with FCoE adapters where DCBX agent is running 
on the 
adapter firmware as compared to managed by SW via lldpad.
I see the patch is not yet applied to the fcoe-utils git tree so a revert patch 
may not be 
necessary.

Thanks,
Neerav
> -----Original Message-----
> From: fcoe-devel [mailto:[email protected]] On Behalf Of
> Neerav Parikh
> Sent: Thursday, March 19, 2015 8:08 PM
> To: [email protected]
> Subject: [Open-FCoE] [PATCH] fcoemon: Don't run the IEEE state machine if
> DCBX not in IEEE mode
> 
> The fcoemon IEEE state machine runs even when DCBX is not in IEEE mode.
> This patch prevents by checking the current DCBX mode before moving ahead
> with the IEEE state machine.
> 
> Tested-by: Jack Morgan <[email protected]>
> Signed-off-by: Neerav Parikh <[email protected]>
> ---
>  fcoemon.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fcoemon.c b/fcoemon.c
> index 3b5210c..7fcc05e 100644
> --- a/fcoemon.c
> +++ b/fcoemon.c
> @@ -3046,6 +3046,9 @@ static void fcm_netif_ieee_advance(struct fcm_netif
> *ff)
>       if (ff->ieee_resp_pending)
>               return;
> 
> +     if (!(ff->dcbx_cap & DCB_CAP_DCBX_VER_IEEE))
> +             return;
> +
>       switch (ff->ieee_state) {
>       case IEEE_INIT:
>               break;
> 
> _______________________________________________
> fcoe-devel mailing list
> [email protected]
> http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel

Reply via email to