On Wed, 2015-08-12 at 13:46 +0200, Johannes Thumshirn wrote: > This patch series replaces all usage of libHBAAPIv2 and libhbalinux2 from > fcoe-utils and replaces them with an internal version operating directly on > the > respective sysfs files. > > This removes the two dependencies but pulls in libpciacces (which got pulled > in > by libhbalinux2 in the current version of fcoe-utils). Nevertheless this way > it > is possible to get rid of a lot of code. >
Yes this is big plus as you said it removes two packages dependency completely libHBAAPI and libhbalinux, significant code removal. However the *old* libHBAAPI is common library across multiple HBA vendors and potentially can be leveraged by all FC/FCoE vendors to manage their FC/FCoE HBA by simply supplying their HBA specific vendor library as libhbalinux for fcoe HBAs. Idea was to use common user tools for all FC/FCoE HBAs but that is still not the case so far, nevertheless libHBAAPI might be still in use by other FC vendors tools since we had some co-existence issues in past with other FC tools install. Also, possibly used in EMC certs tools also. So Johannes are you set to remove libHBAAPI completely ? If so then did you check any other users of libHBAAPI, which could be on released Linux distors also ? Chris Leech from Red Hat is still active on fcoe and he was among original significant contributor to these packages, so adding him for his feedback on removing libHBAAPI. Also adding Hannes from SuSe for same reasons. They might have more to this discussion. Thanks, Vasu > There is one currently known bug, on a NetXtreme II BCM57712 neither the > driver > version nor the serial number is displayed with fcoeadm -i. > > This version also includes some heavy use of asprintf() which I'd like to get > rid of and keep more information on the stack. > > To make things a bit easier to review I've setup a git tree at: > https://github.com/morbidrsa/fcoe-utils/tree/drop-libHBAAPI > > Johannes Thumshirn (9): > fcoe-utils: Add sysfs_hba to to fcoemon_utils > fcoeadm: Use internal sysfs based hba lib for information > fcoeadm: Use internal sysfs lib to display target and LUN info > fcoeadm: Use internal sysfs lib to display port statistics > fcoeadm: Get rid of some includes > fcoemon: Use internal sysfs_hba library > libutil: remove definition of sa_hex_format() > fcping: Convert fcping to internal sysfs based implementation > configure.ac: Remove libHBAAPIv2 and libhbalinux2 > > Makefile.am | 9 +- > configure.ac | 8 +- > fcoe-utils.spec.in | 2 +- > fcoeadm_display.c | 1602 > ++++++++++++++--------------------------------- > fcoeadm_display.h | 4 +- > fcoemon.c | 2 +- > fcping.c | 183 ++---- > include/fcoemon_utils.h | 3 - > include/sysfs_hba.h | 118 ++++ > lib/sysfs_hba.c | 603 ++++++++++++++++++ > 10 files changed, 1271 insertions(+), 1263 deletions(-) > create mode 100644 include/sysfs_hba.h > create mode 100644 lib/sysfs_hba.c > _______________________________________________ fcoe-devel mailing list [email protected] http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
