Vasu Dev <[email protected]> writes:
> On Tue, 2015-09-01 at 10:39 +0200, Johannes Thumshirn wrote:
>> This patch series replaces all usage of libHBAAPIv2 and libhbalinux2 from
>> fcoe-utils and replaces them with an internal version operating directly on
>> the
>> respective sysfs files.
>>
>> This removes the two dependencies but pulls in libpciacces (which got pulled
>> in
>> by libhbalinux2 in the current version of fcoe-utils). Nevertheless this way
>> it
>> is possible to get rid of a lot of code.
>>
>> To make things a bit easier to review I've setup a git tree at:
>> https://github.com/morbidrsa/fcoe-utils/tree/drop-libHBAAPI
>>
>> This version also includes the fixes I posted as a reply to v1 and is tested
>> on
>> an Intel NIC as well as 2 different Broadcom/QLogic NICs.
>>
>
> Johannes, Can you shed your test details ?
As only fcping and fcoeadm are affected by these changes I ran a
combination of it's options (as root and non-root - getting the device's
serial number with fcoeadm -i needs root access for pci config space
access, just like in the old days of libHBAAPI) on the following NICs
(fcoeadm -i output):
QLogic BCM57840 NetXtreme II 10/20-Gigabit Ethernet
QLogic NetXtreme II BCM57712 10 Gigabit Ethernet
Intel 82599ES 10-Gigabit SFI/SFP+ Network Connection
I also did diffs between the old and new output to see nothing has
changed but the capital letters in hexadecimal output.
That's about it. The changes aren't user visible (intentionally) but
make our lives as developers and packagers easier.
As always feedback is welcome, but I might be reacting slower as I'm out
of office the next two weeks.
Thanks,
Johannes
--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
_______________________________________________
fcoe-devel mailing list
[email protected]
http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
