If the thread on the target CPU is not online then all skbs are freed. There is no need to hold p_target's lock during that period.
Cc: Vasu Dev <[email protected]> Cc: "James E.J. Bottomley" <[email protected]> Cc: "Martin K. Petersen" <[email protected]> Cc: Christoph Hellwig <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Sebastian Andrzej Siewior <[email protected]> --- drivers/scsi/fcoe/fcoe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 06f56b7f51c2..a065b31a7a02 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c @@ -1320,9 +1320,10 @@ static void fcoe_percpu_thread_destroy(unsigned int cpu) * new skbs. Unlock the targeted CPU and drop the skbs * on the CPU that is going offline. */ + spin_unlock_bh(&p_target->fcoe_rx_list.lock); + while ((skb = __skb_dequeue(&p->fcoe_rx_list)) != NULL) kfree_skb(skb); - spin_unlock_bh(&p_target->fcoe_rx_list.lock); } } else { /* -- 2.7.0 _______________________________________________ fcoe-devel mailing list [email protected] http://lists.open-fcoe.org/mailman/listinfo/fcoe-devel
