On Tue, 2007-07-10 at 11:53 -0500, Clark Williams wrote: > Jan Kratochvil has submitted a patch to mock that adds the 'orphanskill' > command to > mock-helper (a setuid root program used by mock). The patch traverses the > /proc > directory, looking for tasks with a "root" link that matches the chroot > currently in > use, and sends a SIGKILL to each matching task. > > As far as I can tell this is only useful to the GDB build. The testsuite for > GDB > seems to have some either abnormal terminations or so other oddity that > leaves jobs > hanging. I've looked at the C code and it looks well written, without obvious > security holes. > > I've mixed feelings regarding adding the command. Michael and I have been > fairly > resistant to adding things to mock-helper, on the general principle that > adding > features to a setuid root program is fraught with peril. I see the utility of > the > code, but I'm torn as to whether the 'orphanskill' command is sufficiently > useful to > the general community. > > So, that's the question. Is 'orphanskill' worth adding to mock?
GDB is not the only build that leaves orphaned processes lying around. I've seen similar behavior when building gcc, glibc, and mysql, to name a few. The problems are usually caused by test suites called during the build process, and leaving them around after a build has completed (or failed) can tie up system resources or in some cases cause subsequent builds to fail. Just as mock cleans up the filesystem after a build, it should probably be cleaning up the process list as well. I'd be in favor of adding this patch. Koji could certainly make use of it. -- Fedora-buildsys-list mailing list Fedora-buildsys-list@redhat.com https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
