Hiyas,

Makefile.common uses CVS_EXTRAS_RC to define the variable of the user config 
file and uses a complex structure to only include it, when it is a file.

According to "info make", there is a much easier way:

| If you want `make' to simply ignore a makefile which does not exist
| and cannot be remade, with no error message, use the `-include'
| directive instead of `include', like this:

-include $(HOME)/.cvspkgsrc

Imho, this makes the Makefile much more easier to read and also removes a 
reference to Extras with the variable CVS_EXTRAS_RC.

Regards,
Till
Index: Makefile.common
===================================================================
RCS file: /cvs/pkgs/common/Makefile.common,v
retrieving revision 1.72
diff -u -r1.72 Makefile.common
--- Makefile.common	7 Jul 2007 15:11:29 -0000	1.72
+++ Makefile.common	11 Jul 2007 16:36:58 -0000
@@ -98,10 +98,7 @@
 all: sources
 
 # user specific configuration
-CVS_EXTRAS_RC	:= $(shell if test -f $(HOME)/.cvspkgsrc ; then echo $(HOME)/.cvspkgsrc ; fi)
-ifdef CVS_EXTRAS_RC
-include $(CVS_EXTRAS_RC)
-endif
+-include $(HOME)/.cvspkgsrc
 
 # The repository and the clients we use for the files
 REPOSITORY ?= http://cvs.fedoraproject.org/repo/pkgs
--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list

Reply via email to