A few times I have run into SPECFILE=$(firstword $(wildcard *.spec))
grabbing a different spec file in a pkg cvs dir than intended
when doing local testbuilds. While unlikely I think it would be
embarrassing if one day such an alternate spec somehow ended
up in koji (eg via cvs-import.sh), so I would like to propose
that we hardcode SPECFILE based on package NAME for all new
packages with the attached patch.
Jens
Index: cvs-import.sh
===================================================================
RCS file: /cvs/pkgs/common/cvs-import.sh,v
retrieving revision 1.33
diff -u -r1.33 cvs-import.sh
--- cvs-import.sh 24 Aug 2008 21:50:55 -0000 1.33
+++ cvs-import.sh 16 Jul 2009 06:14:43 -0000
@@ -162,7 +162,7 @@
# Makefile for source rpm: $NAME
# \$Id\$
NAME := $NAME
-SPECFILE = \$(firstword \$(wildcard *.spec))
+SPECFILE = \$(NAME).spec
define find-makefile-common
for d in common ../common ../../common ; do if [ -f \$\$d/Makefile.common ] ; then if [ -f \$\$d/CVS/Root -a -w \$\$/Makefile.common ] ; then cd \$\$d ; cvs -Q update ; fi ; echo "\$\$d/Makefile.common" ; break ; fi ; done
--
Fedora-buildsys-list mailing list
Fedora-buildsys-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-buildsys-list
