Adam, Any idea where that code lives? Or a JIRA ticket or the like?
On Aug 30, 2012, at 12:16 AM, [email protected] wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > FCREPO-855 was just a discussion of the fact that sometimes parameter values > are not actually included in the Atom messages themselves, but the larger > discussion was about how to expose state-changes via the event stream. Steve > Bayliss built a nice module that replaces the current Atom formulation, which > is operation-centered, with a resource-centered formulation that gets (IMHO) > much more to the spirit of Atom-- announcing changes in content. I believe > that he used that code in an integration, but we never got to the point of > merging it into core in any useful way. > > - --- > A. Soroka > Software & Systems Engineering :: Online Library Environment > the University of Virginia Library > > On Aug 29, 2012, at 12:11 PM, Edwin Shin wrote: > >> David, >> >> That looks pretty sensible. >> >> The only thing that's tickling the back of my head is now I remember some >> discussions about larger refactoring of Fedora's messages, but I can't seem >> to find the JIRA tickets. I see a reference to it in one of Adam's comments >> on https://jira.duraspace.org/browse/FCREPO-855. >> >> Any of the other committers recollect more details? >> >> -Eddie >> >> >> On Aug 29, 2012, at 10:39 PM, David Chandek-Stark >> <[email protected]> wrote: >> >>> I'd be glad to work on a test case, but let me first propose adding two >>> interfaces to the client code as shown here: >>> https://gist.github.com/3513264. These are mostly copied from the server >>> code, with the addition of getReturnVal() (from the client class) and >>> getMethodParameterValue() (as discussed here). The intention would be for >>> the client AtomApimMessage class to implement the new APIMMessage interface >>> and to use its (private) getCategoryTerm() method in implementing >>> getMethodParameterValue(). >>> >>> Thanks for considering, >>> David >>> >>>> -----Original Message----- >>>> From: Edwin Shin [mailto:[email protected]] >>>> Sent: Wednesday, August 29, 2012 4:51 AM >>>> To: Support and info exchange list for Fedora users. >>>> Subject: Re: [fcrepo-user] Messaging client AtomApimMessage >>>> getCategoryTerm() method private? >>>> >>>> I suppose the short answer is that via the client class (i.e. not parsing >>>> the >>>> server response yourself), you can't. >>>> >>>> If you can submit a pull request with a test case or two that at least >>>> shows >>>> how you'd like the client class to work, that would be a great starting >>>> point >>>> (unless it's literally just that you want getCategoryTerm not to be >>>> private). >>>> >>>> >>>> On Aug 28, 2012, at 9:15 PM, David Chandek-Stark >>>> <[email protected]> wrote: >>>> >>>>> Thanks for the clear answer. Perhaps add a method to the server >>>> APIMMessage interface for getting the value of the method parameter? But >>>> perhaps I should reframe my question: how is an APIM message consumer >>>> based on fedora-client-messaging supposed to get value of a method >>>> parameter? >>>>> >>>>> Thanks, >>>>> David >>>>> >>>>> -----Original Message----- >>>>> From: Edwin Shin [mailto:[email protected]] >>>>> Sent: Monday, August 27, 2012 10:33 PM >>>>> To: Support and info exchange list for Fedora users. >>>>> Subject: Re: [fcrepo-user] Messaging client AtomApimMessage >>>> getCategoryTerm() method private? >>>>> >>>>> For server, I believe the rationale was something along the lines of only >>>> marking public the methods defined in the interface APIMMessage. >>>>> >>>>> Although I see that getAuthor doesn't quite adhere to that. >>>>> >>>>> Although a categoryTerm is pretty clearly an Atom-specific implementation >>>> detail versus an author. >>>>> >>>>> For fedora-client, the reason is pretty prosaic: the class is just >>>>> directly >>>> descended from the server version. I don't see why we shouldn't make the >>>> method public there. >>>>> >>>>> On Aug 28, 2012, at 2:56 AM, David Chandek-Stark >>>> <[email protected]> wrote: >>>>> >>>>>> Why is the getCategoryTerm() method in the AtomApimMessage class >>>> private? The same question applies also to the server messaging class >>>> AtomAPIMMessage. In both cases, it only denies access to the convenience >>>> of the method, not the message content itself. >>>>>> >>>>>> Thanks, >>>>>> David >>>>>> >>>>>> ---------------------------------------- >>>>>> David Chandek-Stark >>>>>> IT Analyst, Sr. - Perkins Library ITS, Discovery and Core Services >>>>>> Tel. 919-660-5859 >>>>>> IM: [email protected] >>>>>> >>>>> >>>>> >>>>> ---------------------------------------------------------------------- >>>>> -------- >>>>> Live Security Virtual Conference >>>>> Exclusive live event will cover all the ways today's security and >>>>> threat landscape has changed and how IT managers can respond. >>>>> Discussions will include endpoint security, mobile security and the >>>>> latest in malware threats. >>>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>>> _______________________________________________ >>>>> Fedora-commons-users mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/fedora-commons-users >>>>> >>>>> ---------------------------------------------------------------------- >>>>> -------- >>>>> Live Security Virtual Conference >>>>> Exclusive live event will cover all the ways today's security and >>>>> threat landscape has changed and how IT managers can respond. >>>>> Discussions will include endpoint security, mobile security and the >>>>> latest in malware threats. >>>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>>> _______________________________________________ >>>>> Fedora-commons-users mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/fedora-commons-users >>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Live Security Virtual Conference >>>> Exclusive live event will cover all the ways today's security and threat >>>> landscape has changed and how IT managers can respond. Discussions will >>>> include endpoint security, mobile security and the latest in malware >>>> threats. >>>> http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>>> _______________________________________________ >>>> Fedora-commons-users mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/fedora-commons-users >>> >>> ------------------------------------------------------------------------------ >>> Live Security Virtual Conference >>> Exclusive live event will cover all the ways today's security and >>> threat landscape has changed and how IT managers can respond. Discussions >>> will include endpoint security, mobile security and the latest in malware >>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >>> _______________________________________________ >>> Fedora-commons-users mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/fedora-commons-users >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> Fedora-commons-users mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/fedora-commons-users > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG/MacGPG2 v2.0.17 (Darwin) > Comment: GPGTools - http://gpgtools.org > > iQEcBAEBAgAGBQJQPkBhAAoJEATpPYSyaoIklI8H/09G+kdqL3DUk3Hhg9hPuacE > NDQ3U9Kw7eGVwqemGXZvOkRTm/j4/RZa3EXVMbVfxYopAj04BPBL8LbPSNehL9VP > QhAIrefS5aNrkMT+aa8T1/6/yDvzCQkZsKdNkA5JGRM63PpjmGZk7ItMZ+qJcbC7 > HeOrGxkY44+82Y4WZKwlEKlYQNtDuJQo8Jt37OnyGo4cZ8pcM4rIptWnRLh6+wg1 > AMVMqxDGRx0Tyve0JsLFDlgIjtBuRGx197Uf9fVYqPqCVgycxVDth02iccoNsqCg > +lKlZF5fPT7bdiOShucsoLSn0VH7dOOIPUVdfRUpiraG/3bZMcOV6VKuU6NXS1Y= > =xu+R > -----END PGP SIGNATURE----- > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Fedora-commons-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/fedora-commons-users ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Fedora-commons-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/fedora-commons-users
