Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477381





--- Comment #3 from Thorsten Leemhuis <fed...@leemhuis.info>  2008-12-25 
02:08:12 EDT ---
(In reply to comment #2)
> Fonts in the package have been replaced with symlinks to system fonts.

thx for that Wart. 

But please allow me one question reg. the patch:

> +Requires:       dejavu-fonts-experimental bitstream-vera-fonts
> [...]
> +ln -s %{_datadir}/fonts/dejavu/DejaVuSansCondensed.ttf 
> $RPM_BUILD_ROOT%{_datadir}/%{name}/fonts/DejaVuSansCondensed.ttf
> +ln -s %{_datadir}/fonts/bitstream-vera/Vera.ttf 
> $RPM_BUILD_ROOT%{_datadir}/%{name}/fonts/vera_sans.ttf

Maybe a matter of taste, but wouldn't it be better to use those as requires:

Requires: %{_datadir}/%{name}/fonts/DejaVuSansCondensed.ttf
Requires: %{name}/fonts/vera_sans.ttf

That way the broken deps report will yell as soon as the files move (which
breaks the symlinks). That happens rarely (if ever), but I guess sooner or
later it will...

And yes, I'm aware that file deps outside of *bin/ have disadvantages

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-fonts-bugs-list mailing list
Fedora-fonts-bugs-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-fonts-bugs-list

Reply via email to