Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013 [EMAIL PROTECTED] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From [EMAIL PROTECTED] 2006-05-16 11:14 EST ------- - rpmlint checks return: W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/content/tutorial.txt E: python-sqlalchemy wrong-script-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/testdocs.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/txt2myt.py Easily fixed with sed or perl. W: python-sqlalchemy doc-file-dependency /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py /usr/bin/env python will be installed, so this should be fine. - package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream Change source URL to download.sourceforge.net however, to automate downloads. - package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - no need for .desktop file doc web server script thing doesn't work. $ ./runhtml.py : No such file or directory This is end of line problem as mentioned previously. Also, these scripts seem to convert and write html files, which fails due to permissions. You could generate this html in your %install phase, elminating the need for these scripts. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
