Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: blobwars - Mission and Objective based 2D Platform Game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192060 ------- Additional Comments From [EMAIL PROTECTED] 2006-05-30 19:23 EST ------- * rpmlint output clean * Package named according to Package Naming Guidelines * spec file name matches package %{name} * Package meets Packaging Guidelines * Licensed with open source compatible license * License field in spec file matches actual license * License text included in %doc * spec file written in American English * spec file is legible * Sources match upstream 72b259abb6ec83a77f3c76052de24e50 blobwars_1.05.orig.tar.gz * Package successfully compiles and builds on x86_64 FC-5 * All dependencies are specified in BuildRequires - SDL-devel and ImageMagick are extraneous BR * Spec file does not include any locales * Package does not include any shared libraries * Package is not relocatable * Package owns all directories it creates * Package does not contain duplicate files in %files * File permissions are set appropriately * Package contains a proper %clean section * Macro usage is consistant * Package contains permissible content * Package does not contain large documentation to warrent a -doc subpackage * Package does not contain any header files, static libraries or .pc files * Package does not include any library files needed for a -devel subpackage * Package does not contain any .la files * Package includes a proper .desktop file * Package does not own any files or directories owned by other packages === MUST FIX ==== * MUST remove extreanous BR SDL-devel and ImageMagick * MUST remove extreanous "export" in %build section * MUST remove extreanous "-n %{name}-%{version}" under %setup === SHOULD === * Please explain to me why you use patch -z, most examples I've seen use patch -b and I don't understand the differences between these two options. I'm not asking you to use -b, but just explain to me why you use -z. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
