Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480050 --- Comment #11 from Denis Leroy <de...@poolshark.org> 2009-01-26 04:55:06 EDT --- Looks solid. Pretty much agree with Jochen's review here. Minor request : - fold %dir entries in %files, as suggestde by Jochen - maybe fold 3 consecutive %doc lines into 1 ? - devel package gtk-doc Require not necessary (is pulled in by gtk2-devel anyways) - devel package Require on clutter-devel won't be necessary for F-11 Otherwise package looks good. Demo code "launcher.c" won't compile as-is because it unnecessarily include "config.h", probably should notify upstream about that. If you have time, can you sed out that line from it ? (not a review blocker) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
